From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C6C6720248 for ; Fri, 12 Apr 2019 01:26:47 +0000 (UTC) Received: from localhost ([127.0.0.1]:57195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEkxq-0004TC-4Y for normalperson@yhbt.net; Thu, 11 Apr 2019 21:26:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEkxm-0004T6-Qq for bug-gnulib@gnu.org; Thu, 11 Apr 2019 21:26:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEkxk-0007B7-80 for bug-gnulib@gnu.org; Thu, 11 Apr 2019 21:26:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47570) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEkxj-0007AE-SW for bug-gnulib@gnu.org; Thu, 11 Apr 2019 21:26:40 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C32E81DEE; Fri, 12 Apr 2019 01:26:37 +0000 (UTC) Received: from [10.3.117.110] (ovpn-117-110.phx2.redhat.com [10.3.117.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 667365D9CC; Fri, 12 Apr 2019 01:26:36 +0000 (UTC) Subject: Re: Tests on MinGW: undef ref pthread_mutex_lock/unlock To: Bruno Haible , =?UTF-8?Q?Tim_R=c3=bchsen?= References: <4256bd91-1053-6168-d2c4-f42549a2b488@gmx.de> <3195541.m934HO7QNj@omega> <9223407.ZOvgIUZfrP@omega> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <4f8d0ece-731c-4ea4-9c68-3e7d14423621@redhat.com> Date: Thu, 11 Apr 2019 20:26:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <9223407.ZOvgIUZfrP@omega> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9GWnEGMrwqdKv13Vdo2rVZR169tMfb8qI" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 12 Apr 2019 01:26:37 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9GWnEGMrwqdKv13Vdo2rVZR169tMfb8qI Content-Type: multipart/mixed; boundary="ZpPiuv6syU0gnn2vRLM4ZWJirqXHwzUZd"; protected-headers="v1" From: Eric Blake To: Bruno Haible , =?UTF-8?Q?Tim_R=c3=bchsen?= Cc: bug-gnulib@gnu.org Message-ID: <4f8d0ece-731c-4ea4-9c68-3e7d14423621@redhat.com> Subject: Re: Tests on MinGW: undef ref pthread_mutex_lock/unlock References: <4256bd91-1053-6168-d2c4-f42549a2b488@gmx.de> <3195541.m934HO7QNj@omega> <9223407.ZOvgIUZfrP@omega> In-Reply-To: <9223407.ZOvgIUZfrP@omega> --ZpPiuv6syU0gnn2vRLM4ZWJirqXHwzUZd Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/11/19 7:26 PM, Bruno Haible wrote: > Btw, I never build with mingw-pthreads installed. But even with mingw-p= threads > installed, gnulib modules ought to not use it; they ought to use the Wi= ndows > API instead. Jumping in late, but this reminded me of a patch I wrote years ago: https://libvirt.org/git/?p=3Dlibvirt.git;a=3Dcommitdiff;h=3Dc91d13bd > On my Fedora 20 box with mingw cross-compiler, the build failed with: >=20 > ../../src/rpc/virnetclient.c: In function 'virNetClientSetTLSSession': > ../../src/rpc/virnetclient.c:745:14: error: unused variable 'oldmask' [= -Werror=3Dunused-variable] > sigset_t oldmask, blockedsigs; > ^ >=20 > I traced it to the fact that mingw64-winpthreads installs a header > that does #define pthread_sigmask(...) 0, which means any argument > only ever passed to pthread_sigmask is reported as unused. This > patch works around the compilation failure, with behavior no worse > than what mingw already gives us regarding the function being a > no-op. >=20 > * configure.ac (pthread_sigmask): Probe for broken mingw macro. > * src/util/virutil.h (pthread_sigmask): Rewrite to something that > avoids unused variables. Here we are 5 years later, and mingw32-winpthreads-5.0.4-2.fd29 still has a broken: /usr/i686-w64-mingw32/sys-root/mingw/include/pthread_signal.h: #define pthread_sigmask(H, S1, S2) 0 So indeed, gnulib could do a better job at avoiding that library as more pain than it is worth. --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --ZpPiuv6syU0gnn2vRLM4ZWJirqXHwzUZd-- --9GWnEGMrwqdKv13Vdo2rVZR169tMfb8qI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlyv6UsACgkQp6FrSiUn Q2oeiggAkeDGxECLlm4EUNisqVGef58ce8h5n+jNEE8ApJLe2Io2BBN7yRpRxvw1 zew8qWYqe0TdI2PEd1fO+/InmsNqtRpCb8e+s6rl2cdFvVjTmCub5DmeQKTQnyfA yKxh2iGlB6QDObhsjQJlZ3FaSXWzcT6O/of9OLxV0y2/8ombjT419Qsb/QtK20wJ 719blBXyXfgWDx9jmMA7JEuFiyOdN1d/suxKIBx5jBi+GlfLc2jBCYcdUQmg1oCx 63d4BWs94LVN54ZOGTbEgV9MWZYmuq3vP4ZFfAUdaIcvWROAWOLk9ViUa8WwGzBS 9sKal6Jaqip4DZsUb0Zbeu4TjGUKLw== =BKAl -----END PGP SIGNATURE----- --9GWnEGMrwqdKv13Vdo2rVZR169tMfb8qI--