From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 689AD1F8C6 for ; Wed, 11 Aug 2021 07:24:39 +0000 (UTC) Received: from localhost ([::1]:37968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDibO-0001NJ-71 for normalperson@yhbt.net; Wed, 11 Aug 2021 03:24:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDibL-0001Mu-44 for bug-gnulib@gnu.org; Wed, 11 Aug 2021 03:24:35 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46274) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDibI-0001d5-Oe for bug-gnulib@gnu.org; Wed, 11 Aug 2021 03:24:34 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 49F101600F1; Wed, 11 Aug 2021 00:24:30 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id LqBC2UaxOSDq; Wed, 11 Aug 2021 00:24:25 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9B6D31600F3; Wed, 11 Aug 2021 00:24:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id J64H2KHAwEC8; Wed, 11 Aug 2021 00:24:25 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 76F7D1600F1; Wed, 11 Aug 2021 00:24:25 -0700 (PDT) To: Darren Kenny , bug-gnulib@gnu.org References: <3932753cd7929507688d341754fae944dac9a983.1624030621.git.darren.kenny@oracle.com> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: [PATCH 3/3] lib/regexec: Resolve unused variable Message-ID: <4cec2520-759b-cb6d-172f-0120f42a4cfe@cs.ucla.edu> Date: Wed, 11 Aug 2021 00:24:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3932753cd7929507688d341754fae944dac9a983.1624030621.git.darren.kenny@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" On 6/18/21 8:44 AM, Darren Kenny wrote: > The reason for this issue is that we are not building with DEBUG set an= d > this in turn means that the assert() that reads the value of the > variable match_last is being processed out. Unfortunately I don't understand the scenario here. If not building with=20 DEBUG, 'DEBUG_ASSERT (match_last !=3D 1)' should expand to 'assume=20 (match_last !=3D 1)', which in turn should expand to something that=20 evaluates the expression 'match_last !=3D 1'. Please see this commit,=20 which removed the "#ifdef" that you're proposing to re-add: https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=3D79f8ee4e389f8cb= 1339f8abed9a7d29816e2a2d4