bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Collin Funk <collin.funk1@gmail.com>
Subject: Re: [PATCH] gnulib-tool.py: Comment out undefined variable.
Date: Wed, 21 Feb 2024 17:08:43 +0100	[thread overview]
Message-ID: <4938842.YqazSvReao@nimes> (raw)
In-Reply-To: <28bebd33-fb40-4d40-9ec2-87988d82c10a@gmail.com>

Collin Funk wrote:
>     self.config.setAuxDir(saved_auxdir)
>                           ^^^^^^^^^^^^
> NameError: name 'saved_auxdir' is not defined
> I commented out the offending line instead of removing it just in case
> it is useful in the future.

I suppose it is not much more work to fix this line for real?
  - If there is no variable 'saved_auxdir' in this function, maybe there
    is a variable 'auxdir'?
  - What do the comments hint at?
  - What does the history of the file ('gitk pygnulib/GLTestDir.py',
    'git annotate pygnulib/GLTestDir.py') tell you?


  reply	other threads:[~2024-02-21 16:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 11:36 [PATCH] gnulib-tool.py: Comment out undefined variable Collin Funk
2024-02-21 16:08 ` Bruno Haible [this message]
2024-02-21 17:17   ` Collin Funk
2024-02-21 17:29     ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4938842.YqazSvReao@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=collin.funk1@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).