From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C1DD91F44D for ; Mon, 15 Apr 2024 16:21:41 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Ea9gnjvN; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwP58-0001Nz-CF; Mon, 15 Apr 2024 12:21:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwP55-0001Na-5W for bug-gnulib@gnu.org; Mon, 15 Apr 2024 12:21:19 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwP53-0000i9-7E for bug-gnulib@gnu.org; Mon, 15 Apr 2024 12:21:18 -0400 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-2a519ac18b3so2431871a91.2 for ; Mon, 15 Apr 2024 09:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713198074; x=1713802874; darn=gnu.org; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=i9eD+ojQr6jSGKWp+7NLGd7d0WXdL0kqywbO/6mTBBg=; b=Ea9gnjvN6lzU8SiEB2dNxMYqTs0WZ0v1fkQwR2IuezUojGgcwArYnxVhnvLZNQFWYE KJmlnTkcQy9rr7/bcLfMYSaCTzpRm+njLrKNScsaoVZfq3vL3bPkC1Bs1SPQFFjGQr// +BUycX4eG5JGfOfq/HiWucu1U28Z6nKy4OXjBALq63gQB4883ckCBTD//FMu9bmzaEOw Umo7aIIa+ifKxe5aGf5W44x+ezQRKbUkm+0L/sLClSmbbVMnSZryIRuIsox794jB5Smh 2L5Rc4mj5AsAHupD2QJSoG4r/rkGNcZA9akpkJBiqr7cQfuz7+xKQ3ZursO/J50Vu+O7 HJfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713198074; x=1713802874; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i9eD+ojQr6jSGKWp+7NLGd7d0WXdL0kqywbO/6mTBBg=; b=vrmJ45MPmaujRUBa5hU19cCiVs6of2z+dyeyyk44tr4ItCJ/pWrpaTSGClWCq4K78m lzyjhUyVXKM4BrJplfRE/08tJSCPiZ40g4ohYtSybjR7UQtuJJtAFblhQfpNZnv521dV AbKNfCHslc8e5jpidBfMh0NsAr7splI220xd7B+8ctUFcaNnUYALtKCZ/T2eO0LM7EN4 ORzygdw1Yawvj5fGAIYUphyr2sMmIOuLg3CfJbimRzqoQ//lSn3JiyaiwnMEdE89lGCM 3GcQwV66LylU6I7prkbX6LJ/femtLO5ZhwBWxJfA6Abz3phOPTpGr9lP0S1yCNT7udlH MnhA== X-Gm-Message-State: AOJu0YxbK7rtg4EwFT29xbxy1Ma8Sh2+nsUbUumcN7L39UBE70DLckTV wHJ8GwOKACwd0DH053I4+pAfl8miJw5Ggkz7q9mcwsPrjnT/zZvjgsM3qw== X-Google-Smtp-Source: AGHT+IGOWeOYS07afeJ1+2PiUp3oz0EkbGTktEeiGWCbxSQqcbL3+0IdzQqO3AY7wSsF+RQKxyFIFA== X-Received: by 2002:a17:90a:bc8e:b0:2a4:76b6:8456 with SMTP id x14-20020a17090abc8e00b002a476b68456mr7492066pjr.10.1713198074324; Mon, 15 Apr 2024 09:21:14 -0700 (PDT) Received: from [192.168.1.5] (c-73-189-213-139.hsd1.ca.comcast.net. [73.189.213.139]) by smtp.gmail.com with ESMTPSA id o21-20020a17090ad25500b0029de90f4d44sm9200767pjw.9.2024.04.15.09.21.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 09:21:13 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------QZ2QNusRqmxMQ99rnx4oLPYr" Message-ID: <48e0961d-1af4-4677-b06c-ee896f210f4e@gmail.com> Date: Mon, 15 Apr 2024 09:21:12 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: bug-gnulib@gnu.org, Bruno Haible From: Collin Funk Subject: gnulib-tool.py: Optimize directory creation. Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=collin.funk1@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org This is a multi-part message in MIME format. --------------QZ2QNusRqmxMQ99rnx4oLPYr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Bruno, Separating this from the other thread so it is easier to follow. This patch handles the directory creation upfront instead of checking for every single file, as you mentioned earlier [1]. The previously unused variable was slightly incorrect. We have to join the directory name with self.testdir. I ran it without this and the directories were made in the current working directory, causing the tests to crash. [1] https://lists.gnu.org/archive/html/bug-gnulib/2024-04/msg00245.html Collin --------------QZ2QNusRqmxMQ99rnx4oLPYr Content-Type: text/x-patch; charset=UTF-8; name="0001-gnulib-tool.py-Optimize-directory-creation.patch" Content-Disposition: attachment; filename="0001-gnulib-tool.py-Optimize-directory-creation.patch" Content-Transfer-Encoding: base64 RnJvbSA3MDlmZjI4MmMwMDkzZjY5NjU5NDgxMDI5OGJkYzIxYzI1MTQ4OWNkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDb2xsaW4gRnVuayA8Y29sbGluLmZ1bmsxQGdtYWls LmNvbT4KRGF0ZTogTW9uLCAxNSBBcHIgMjAyNCAwOToxNjoyNSAtMDcwMApTdWJqZWN0OiBb UEFUQ0hdIGdudWxpYi10b29sLnB5OiBPcHRpbWl6ZSBkaXJlY3RvcnkgY3JlYXRpb24uCgoq IHB5Z251bGliL0dMVGVzdERpci5weSAoR0xUZXN0RGlyLmV4ZWN1dGUpOiBVc2UgYSBsaXN0 IG9mIHBvc3NpYmxlCnN1YmRpcmVjdG9yaWVzIGFuZCBjcmVhdGUgdGhlbSB1cGZyb250IGlu c3RlYWQgb2YgY2hlY2tpbmcgZXZlcnkgZmlsZS4KLS0tCiBDaGFuZ2VMb2cgICAgICAgICAg ICAgfCAgNiArKysrKysKIHB5Z251bGliL0dMVGVzdERpci5weSB8IDEwICsrKysrLS0tLS0K IDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNWI3YjNhMzZmYy4uY2Zm M2IxYzA0OCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDkgQEAKKzIwMjQtMDQtMTUgIENvbGxpbiBGdW5rICA8Y29sbGluLmZ1bmsxQGdtYWls LmNvbT4KKworCWdudWxpYi10b29sLnB5OiBPcHRpbWl6ZSBkaXJlY3RvcnkgY3JlYXRpb24u CisJKiBweWdudWxpYi9HTFRlc3REaXIucHkgKEdMVGVzdERpci5leGVjdXRlKTogVXNlIGEg bGlzdCBvZiBwb3NzaWJsZQorCXN1YmRpcmVjdG9yaWVzIGFuZCBjcmVhdGUgdGhlbSB1cGZy b250IGluc3RlYWQgb2YgY2hlY2tpbmcgZXZlcnkgZmlsZS4KKwogMjAyNC0wNC0xNCAgQ29s bGluIEZ1bmsgIDxjb2xsaW4uZnVuazFAZ21haWwuY29tPgogCiAJZ251bGliLXRvb2wucHk6 IEZpeCBpbmNvcnJlY3QgdHlwZSBoaW50LgpkaWZmIC0tZ2l0IGEvcHlnbnVsaWIvR0xUZXN0 RGlyLnB5IGIvcHlnbnVsaWIvR0xUZXN0RGlyLnB5CmluZGV4IGE3NzA5YTEyNTkuLmI2Njg2 MjlmNGQgMTAwNjQ0Ci0tLSBhL3B5Z251bGliL0dMVGVzdERpci5weQorKysgYi9weWdudWxp Yi9HTFRlc3REaXIucHkKQEAgLTM0NSw5ICszNDUsMTIgQEAgZGVmIGV4ZWN1dGUoc2VsZikg LT4gTm9uZToKICAgICAgICAgZmlsZWxpc3QgPSBzb3J0ZWQoc2V0KGZpbGVsaXN0KSkKIAog ICAgICAgICAjIENyZWF0ZSBkaXJlY3Rvcmllcy4KLSAgICAgICAgZGlyZWN0b3JpZXMgPSBb b3MucGF0aC5kaXJuYW1lKGZpbGUpCi0gICAgICAgICAgICAgICAgICAgICAgIGZvciBmaWxl IGluIHNlbGYucmV3cml0ZV9maWxlcyhmaWxlbGlzdCldCisgICAgICAgIGRpcmVjdG9yaWVz ID0gWyBqb2lucGF0aChzZWxmLnRlc3RkaXIsIG9zLnBhdGguZGlybmFtZShmaWxlKSkKKyAg ICAgICAgICAgICAgICAgICAgICAgIGZvciBmaWxlIGluIHNlbGYucmV3cml0ZV9maWxlcyhm aWxlbGlzdCkgXQogICAgICAgICBkaXJlY3RvcmllcyA9IHNvcnRlZChzZXQoZGlyZWN0b3Jp ZXMpKQorICAgICAgICBmb3IgZGlyZWN0b3J5IGluIGRpcmVjdG9yaWVzOgorICAgICAgICAg ICAgaWYgbm90IGlzZGlyKGRpcmVjdG9yeSk6CisgICAgICAgICAgICAgICAgb3MubWFrZWRp cnMoZGlyZWN0b3J5KQogCiAgICAgICAgICMgQ29weSBmaWxlcyBvciBtYWtlIHN5bWJvbGlj IGxpbmtzIG9yIGhhcmQgbGlua3MuCiAgICAgICAgIGZpbGV0YWJsZSA9IFtdCkBAIC0zNTgs OSArMzYxLDYgQEAgZGVmIGV4ZWN1dGUoc2VsZikgLT4gTm9uZToKICAgICAgICAgICAgIHNy YyA9IHJvd1sxXQogICAgICAgICAgICAgZGVzdCA9IHJvd1swXQogICAgICAgICAgICAgZGVz dHBhdGggPSBqb2lucGF0aChzZWxmLnRlc3RkaXIsIGRlc3QpCi0gICAgICAgICAgICBkaXJu YW1lID0gb3MucGF0aC5kaXJuYW1lKGRlc3RwYXRoKQotICAgICAgICAgICAgaWYgbm90IGlz ZGlyKGRpcm5hbWUpOgotICAgICAgICAgICAgICAgIG9zLm1ha2VkaXJzKGRpcm5hbWUpCiAg ICAgICAgICAgICBpZiBzcmMuc3RhcnRzd2l0aCgndGVzdHM9bGliLycpOgogICAgICAgICAg ICAgICAgIHNyYyA9IGNvbnN0YW50cy5zdWJzdGFydCgndGVzdHM9bGliLycsICdsaWIvJywg c3JjKQogICAgICAgICAgICAgbG9va2VkdXAsIGZsYWcgPSBzZWxmLmZpbGVzeXN0ZW0ubG9v a3VwKHNyYykKLS0gCjIuNDQuMAoK --------------QZ2QNusRqmxMQ99rnx4oLPYr--