From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B0DED1FB08 for ; Wed, 2 Dec 2020 21:52:33 +0000 (UTC) Received: from localhost ([::1]:48600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kka36-00015h-SO for normalperson@yhbt.net; Wed, 02 Dec 2020 16:52:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kka2y-00015O-H5 for bug-gnulib@gnu.org; Wed, 02 Dec 2020 16:52:24 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.24]:23450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kka2v-0001hZ-T0 for bug-gnulib@gnu.org; Wed, 02 Dec 2020 16:52:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1606945939; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=iH6YjIDNIpBjPSASkL/cvxDhFQYMySaDBtyUTn9gO9U=; b=lhtjzssfW5cm8T5LdUYb1En3g+dIbMe7scNrIapdKN2ZHwch9I/242lqsTM8W6cdKh Y59COY2ae1FZZFDHg78cVYCyhc7JluufkVHUfN9DdpiPddX14GNI1tYvdqOIdYEAShwW O1JAa8kyIWU77nm4gtAZhfoS7OmLedRcaYzD5l30eiN8/kVT3jeifBQ4yakDJxgpU0jR FSImKvdd2aUwirAYsBBS457f0dWYZYT4Fa3ANVoA0d6lfYq82moy1i9snwad5VXJoczT diNy5EDdg1/PI9PaZ9dFGHHFSp7L+w0Y0LjDlct3488eHaYaNHaQ7EHz+JC1Atq3+WmD T1ww== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGaf0yJVW" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 47.3.4 DYNA|AUTH) with ESMTPSA id V00800wB2LqIvJk (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Wed, 2 Dec 2020 22:52:18 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: strsignal on macOS Date: Wed, 02 Dec 2020 22:52:17 +0100 Message-ID: <4648086.YSxEm46IZp@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-193-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Received-SPF: none client-ip=85.215.255.24; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin =?ISO-8859-1?Q?Storsj=F6?= Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Martin Storsj=F6 wrote: > FAIL: test-strsignal The cause is that strsignal (SIGHUP) here is "Hangup 1", not just "Hangup". This patch fixes the test. 2020-12-02 Bruno Haible strsignal-tests: Fix test failure on macOS 10.13. Reported by Martin Storsj=F6 in . * tests/test-strsignal.c (ASSERT_DESCRIPTION): Allow the actual result to be longer than the expected result. diff --git a/tests/test-strsignal.c b/tests/test-strsignal.c index 0316d40..1f8aeba 100644 =2D-- a/tests/test-strsignal.c +++ b/tests/test-strsignal.c @@ -28,10 +28,12 @@ SIGNATURE_CHECK (strsignal, char *, (int)); #include "macros.h" =20 #if HAVE_DECL_SYS_SIGLIST =2D# define ASSERT_DESCRIPTION(got, expect) +# define ASSERT_DESCRIPTION(actual, expected) #else =2D/* In this case, we can guarantee some signal descriptions. */ =2D# define ASSERT_DESCRIPTION(got, expect) ASSERT (!strcmp (got, expect)) +/* In this case, we can guarantee some signal descriptions. + But allow the actual result to be longer than the expected result. */ +# define ASSERT_DESCRIPTION(actual, expected) \ + ASSERT (strncmp (actual, expected, strlen (expected)) =3D=3D 0) #endif =20 int