bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Collin Funk <collin.funk1@gmail.com>
Subject: Re: [PATCH] math: Silence -Winclude-next-absolute-path warning.
Date: Sat, 17 Feb 2024 11:51:24 +0100	[thread overview]
Message-ID: <4628522.22IY78Rhhi@nimes> (raw)
In-Reply-To: <fe1369b8-4457-4a4c-a520-d11f59f31e64@gmail.com>

Collin Funk wrote:
> Hello. When compiling gettext from master I get the following warning:
> 
> ./math.h:46:2: warning: #include_next in file found relative to primary source file or found by absolute path; will search from start of include path [-Winclude-next-absolute-path]
>    46 | #include_next <math.h>
> 
> I've attached a patch that seems to fix this. I based it off the following two commits:
> 
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=f4fccf8efdd09d5e38f49f6ae1962797ce3e8e9c
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=2a5409cf2ac62ed273589c72bb8ae0031f06a219

Thanks, applied!

I also applied this patch, to complete
<https://lists.gnu.org/archive/html/bug-gnulib/2023-12/msg00072.html>:


2024-02-17  Bruno Haible  <bruno@clisp.org>

	error: More clang -Winclude-next-absolute-path silencing.
	* modules/error-h (Include): Suggest <error.h>, not "error.h".
	* m4/error_h.m4: Write #include <error.h>.

diff --git a/m4/error_h.m4 b/m4/error_h.m4
index f8016ce3f8..006770c4d3 100644
--- a/m4/error_h.m4
+++ b/m4/error_h.m4
@@ -5,7 +5,7 @@
 dnl with or without modifications, as long as this notice is preserved.
 
 dnl From Bruno Haible.
-dnl Provide a working "error.h".
+dnl Provide a working <error.h>.
 
 AC_DEFUN_ONCE([gl_ERROR_H],
 [
diff --git a/modules/error-h b/modules/error-h
index eeb5801732..2f43279d1b 100644
--- a/modules/error-h
+++ b/modules/error-h
@@ -35,7 +35,7 @@ error.h: error.in.h $(top_builddir)/config.status $(CXXDEFS_H)
 MOSTLYCLEANFILES += error.h error.h-t
 
 Include:
-"error.h"
+<error.h>
 
 License:
 LGPLv2+





  reply	other threads:[~2024-02-17 10:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17  8:36 [PATCH] math: Silence -Winclude-next-absolute-path warning Collin Funk
2024-02-17 10:51 ` Bruno Haible [this message]
2024-02-17 12:26   ` Collin Funk
2024-02-17 13:17     ` Bruno Haible
2024-02-18 12:19     ` Bruno Haible
2024-02-18 12:44       ` syntax-check rule to silence " Bruno Haible
2024-02-18 20:12         ` Collin Funk
2024-02-18 20:33           ` Bruno Haible
2024-02-19  5:02             ` Jim Meyering
2024-02-19 18:11               ` Collin Funk
2024-02-19 18:32                 ` Jim Meyering
2024-02-19  8:45             ` Simon Josefsson via Gnulib discussion list
2024-02-19 20:39               ` Jim Meyering
2024-02-20 15:17               ` Bruno Haible
2024-02-20 20:23         ` Collin Funk
2024-02-20 20:49           ` Bruno Haible
2024-02-19  6:31       ` [PATCH] math: Silence " Paul Eggert
2024-02-19 11:03         ` Bruno Haible
2024-02-19 20:41           ` Paul Eggert
2024-02-19 21:24             ` Bruno Haible
2024-02-19 21:45               ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4628522.22IY78Rhhi@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=collin.funk1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).