From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: execute tests: Avoid test failure on Android
Date: Tue, 17 Jan 2023 15:21:52 +0100 [thread overview]
Message-ID: <4520176.VQJxnDRnGh@nimes> (raw)
On Android 11, I'm seeing a test failure:
FAIL: test-execute.sh
=====================
test-execute-main: test-execute-child subprocess failed
../../gltests/test-execute-main.c:138: assertion 'ret == 127' failed
Aborted
test-execute.sh: test case 3 failed
../../gltests/test-execute-main.c:151: assertion 'ret == 0' failed
Aborted
test-execute.sh: test case 4 failed
FAIL test-execute.sh (exit status: 1)
When I run
make check TESTS=test-execute.sh
or
rm -f test-execute.sh.log; make test-execute.sh.log
I see the test cases 3 and 4 fail, because the child program has
exited with exit code 71.
Whereas when I run
../../gltests/test-execute.sh
directly, all the tests pass.
Apparently the SIGPIPE handler gets set to SIG_IGN, either by 'make' or
by the test-driver.
This patch implements a workaround.
2023-01-17 Bruno Haible <bruno@clisp.org>
execute tests: Avoid test failure on Android.
* tests/test-execute-main.c (main): Reset the SIGPIPE handler to
default.
diff --git a/tests/test-execute-main.c b/tests/test-execute-main.c
index d89b34465b..fbaa9c9d2e 100644
--- a/tests/test-execute-main.c
+++ b/tests/test-execute-main.c
@@ -58,6 +58,18 @@ main (int argc, char *argv[])
const char *progname = "test-execute-child";
int test = atoi (argv[2]);
+#if defined __ANDROID__
+ /* On Android 11, when this test is executed through 'make' (GNU make 4.4) and
+ build-aux/test-driver, i.e. through
+ make check TESTS=test-execute.sh
+ or
+ rm -f test-execute.sh.log; make test-execute.sh.log
+ the signal handler for SIGPIPE is set to SIG_IGN. This causes the tests
+ 3 and 4 to fail. Work around it by resetting the signal handler for
+ SIGPIPE to the default. */
+ signal (SIGPIPE, SIG_DFL);
+#endif
+
switch (test)
{
case 14:
next reply other threads:[~2023-01-17 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 14:21 Bruno Haible [this message]
2023-01-17 19:42 ` execute tests: Avoid test failure on Android Eric Blake
2023-01-17 21:15 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4520176.VQJxnDRnGh@nimes \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).