bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Collin Funk <collin.funk1@gmail.com>
To: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Subject: Re: Can we have gnulib-tool.py emit the same copyright header?
Date: Tue, 27 Feb 2024 18:51:32 -0800	[thread overview]
Message-ID: <42da1cf2-80a6-44d4-a75a-0b21f38da205@gmail.com> (raw)
In-Reply-To: <7024084.N7aMVyhfb1@nimes>

On 2/27/24 6:26 PM, Bruno Haible wrote:
> git log -n 1 ChangeLog | grep ^Date:

Ah, I see what is happening.

[collin@debian gnulib]$ git log -n 1
commit 431d6a7615245e6b32d95b4b27aab5d3af65ad2b (HEAD -> master, origin/master, origin/HEAD)
Author:     Bruno Haible <bruno@clisp.org>
AuthorDate: Wed Feb 28 00:33:49 2024 +0100
Commit:     Bruno Haible <bruno@clisp.org>
CommitDate: Wed Feb 28 00:33:49 2024 +0100

    isnan: Fix compilation error in C++ mode on OpenBSD 7.5-beta.
    
    Reported by Christian Weisgerber <naddy@mips.inka.de> in
    <https://lists.gnu.org/archive/html/bug-gnulib/2024-02/msg00261.html>.
    
    * lib/math.in.h (GNULIB_NAMESPACE_LACKS_ISNAN): Define on all platforms
    with clang ≥ 14.

So the grep ^Date fails. I don't remember changing this but in my git
config it is caused by this [1]:

[format]
	pretty = fuller

The regular gnulib-tool gives me this:

[collin@debian gnulib]$ gnulib-tool --version
gnulib-tool (GNU gnulib 2024-02-28 00:00:00) 0.1.7153-431d6
Copyright (C) 2024 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Bruno Haible, Paul Eggert, and Simon Josefsson.

It seems that some people might have their git log settings so that
there isn't even a date or name:

[collin@debian gnulib]$ git log --pretty=oneline
431d6a7615245e6b32d95b4b27aab5d3af65ad2b (HEAD -> master, origin/master, origin/HEAD) isnan: Fix compilation error in C++ mode on OpenBSD 7.5-beta.
38a9bb6e0ae3f5c71da8eb5db5ea7aa41b14f3e4 gnulib-tool.py: Fix configure.ac output.
e1f51c8e0431fe2598479daf76690e1d4d7c1a88 gnulib-tool.py: Follow gnulib-tool changes, part 31.
bb09847b7d87d1c99a29f889372bc4771eb9d2bd gnulib-tool.py: Small fix of part 27.

I wonder which version this feature was added... I'm not sure how git
will act with invalid arguments but ideally we could run something
like:

[collin@debian gnulib]$ git log --pretty=medium -n 1 | grep '^Date:'
Date:   Wed Feb 28 00:33:49 2024 +0100

I think medium looks like the default, but I'd have to double check.

[1] https://git-scm.com/docs/pretty-formats

Collin


  reply	other threads:[~2024-02-28  2:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  1:41 Can we have gnulib-tool.py emit the same copyright header? Collin Funk
2024-02-28  2:07 ` Bruno Haible
2024-02-28  2:19   ` Collin Funk
2024-02-28  2:26     ` Bruno Haible
2024-02-28  2:51       ` Collin Funk [this message]
2024-02-28  7:53         ` Collin Funk
2024-02-28 11:00           ` Bruno Haible
2024-02-28 21:18             ` Collin Funk
2024-02-28 21:30               ` Bruno Haible
2024-02-28 21:48                 ` Collin Funk
2024-02-28 23:34                   ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42da1cf2-80a6-44d4-a75a-0b21f38da205@gmail.com \
    --to=collin.funk1@gmail.com \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).