* Re: [PATCH] gdb: Fix build error on macOS
[not found] <MEAP282MB029370891A815AD567B60CBDDDAE9@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM>
@ 2021-10-05 4:51 ` Enze Li
2021-10-06 0:05 ` Bruno Haible
0 siblings, 1 reply; 2+ messages in thread
From: Enze Li @ 2021-10-05 4:51 UTC (permalink / raw)
To: gdb-patches, bug-gnulib; +Cc: simon.marchi
[ add bug-gnulib@gnu.org ]
On 10/4/21 6:03 PM, Enze Li via Gdb-patches wrote:
> PR build/28413 notes that the gdb master fails to build on macOS.
>
> Based on De Morgan's law, the expression
> !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
> is equal to (!defined __GNUC__ || defined __clang__ || !__OPTIMIZE).
> The expression above looks weird, maybe there are some problems with
> this way of judging. When any one of the conditions is established, the
> subsequent judgment will be ignored.
>
> This patch works around the issue by rewriting the expression of
> judgment after referring to the nearby notes.
>
> Tested by building on x86_64-Linux and macOS(Mojave & Catalina).
>
> Bug: https://sourceware.org/PR28413
> ---
> gnulib/import/c++defs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnulib/import/c++defs.h b/gnulib/import/c++defs.h
> index 39df1bc76bc..dbbae2f1fa2 100644
> --- a/gnulib/import/c++defs.h
> +++ b/gnulib/import/c++defs.h
> @@ -286,7 +286,7 @@
> _GL_CXXALIASWARN_2 (func, namespace)
> /* To work around GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43881>,
> we enable the warning only when not optimizing. */
> -# if !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
> +# if defined __GNUC__ && !defined __clang__ && !__OPTIMIZE__
> # define _GL_CXXALIASWARN_2(func,namespace) \
> _GL_WARN_ON_USE (func, \
> "The symbol ::" #func " refers to the system function. " \
> @@ -314,7 +314,7 @@
> _GL_CXXALIASWARN1_2 (func, rettype, parameters_and_attributes, namespace)
> /* To work around GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43881>,
> we enable the warning only when not optimizing. */
> -# if !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
> +# if defined __GNUC__ && !defined __clang__ && !__OPTIMIZE__
> # define _GL_CXXALIASWARN1_2(func,rettype,parameters_and_attributes,namespace) \
> _GL_WARN_ON_USE_CXX (func, rettype, rettype, parameters_and_attributes, \
> "The symbol ::" #func " refers to the system function. " \
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gdb: Fix build error on macOS
2021-10-05 4:51 ` [PATCH] gdb: Fix build error on macOS Enze Li
@ 2021-10-06 0:05 ` Bruno Haible
0 siblings, 0 replies; 2+ messages in thread
From: Bruno Haible @ 2021-10-06 0:05 UTC (permalink / raw)
To: gdb-patches, bug-gnulib; +Cc: Enze Li, simon.marchi
Enze Li wrote:
> > PR build/28413 notes that the gdb master fails to build on macOS.
The build fails due to the combination of '-Werror' and a useful
warning emitted by Gnulib.
But Gnulib does not support '-Werror'. To fix the issue, you need to
filter out the '-Werror' option. Or not add it in the first place.
> > Based on De Morgan's law, the expression
> > !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
> > is equal to (!defined __GNUC__ || defined __clang__ || !__OPTIMIZE).
> > The expression above looks weird, maybe there are some problems with
> > this way of judging. When any one of the conditions is established, the
> > subsequent judgment will be ignored.
> >
> > This patch works around the issue by rewriting the expression of
> > judgment after referring to the nearby notes.
This text does not explain what the patch does.
> > --- a/gnulib/import/c++defs.h
> > +++ b/gnulib/import/c++defs.h
> > @@ -286,7 +286,7 @@
> > _GL_CXXALIASWARN_2 (func, namespace)
> > /* To work around GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43881>,
> > we enable the warning only when not optimizing. */
> > -# if !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
> > +# if defined __GNUC__ && !defined __clang__ && !__OPTIMIZE__
> > # define _GL_CXXALIASWARN_2(func,namespace) \
> > _GL_WARN_ON_USE (func, \
> > "The symbol ::" #func " refers to the system function. " \
The previous code enables a useful warning for clang, and does not enable it
for GCC because that would trigger a GCC bug.
Your patch swaps the cases of clang and GCC. Thus it removes a useful warning
for clang builds, and triggers a known GCC bug in the GCC builds.
> > @@ -314,7 +314,7 @@
> > _GL_CXXALIASWARN1_2 (func, rettype, parameters_and_attributes, namespace)
> > /* To work around GCC bug <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43881>,
> > we enable the warning only when not optimizing. */
> > -# if !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
> > +# if defined __GNUC__ && !defined __clang__ && !__OPTIMIZE__
> > # define _GL_CXXALIASWARN1_2(func,rettype,parameters_and_attributes,namespace) \
> > _GL_WARN_ON_USE_CXX (func, rettype, rettype, parameters_and_attributes, \
> > "The symbol ::" #func " refers to the system function. " \
Likewise.
So, the patch is bad on all accounts.
Bruno
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-06 0:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <MEAP282MB029370891A815AD567B60CBDDDAE9@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM>
2021-10-05 4:51 ` [PATCH] gdb: Fix build error on macOS Enze Li
2021-10-06 0:05 ` Bruno Haible
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).