bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: git-version-gen: allow 'snapshot' as .tarball-version contents
Date: Sun, 13 Oct 2019 18:30:47 +0200	[thread overview]
Message-ID: <4073770.ak1ocBl5qt@omega> (raw)

Hi,

git-version-gen currently rejects some forms of .tarball-version:

$ cat > .tarball-version
20191011
$ build-aux/git-version-gen .tarball-version; echo
20191011
$ cat > .tarball-version
snapshot
$ build-aux/git-version-gen .tarball-version; echo
build-aux/git-version-gen: WARNING: .tarball-version is missing or damaged
UNKNOWN

I need a non-numeric version for continuous publishing of gettext snapshot
tarballs, and I want the tarballs to be called gettext-snapshot.tar.gz,
not gettext-UNKNOWN.tar.gz.

This patch fixes the problem.


2019-10-13  Bruno Haible  <bruno@clisp.org>

	git-version-gen: Allow 'snapshot' as .tarball-version contents.
	* build-aux/git-version-gen: Don't map non-numeric .tarball-version
	contents to the empty string.

diff --git a/build-aux/git-version-gen b/build-aux/git-version-gen
index 45b5656..d855645 100755
--- a/build-aux/git-version-gen
+++ b/build-aux/git-version-gen
@@ -142,11 +142,9 @@ then
     v=`cat $tarball_version_file` || v=
     case $v in
         *$nl*) v= ;; # reject multi-line output
-        [0-9]*) ;;
-        *) v= ;;
     esac
     test "x$v" = x \
-        && echo "$0: WARNING: $tarball_version_file is missing or damaged" 1>&2
+        && echo "$0: WARNING: $tarball_version_file is damaged" 1>&2
 fi
 
 if test "x$v" != x



             reply	other threads:[~2019-10-13 16:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-13 16:30 Bruno Haible [this message]
2019-10-13 19:52 ` git-version-gen: allow 'snapshot' as .tarball-version contents Dmitry V. Levin
2019-10-13 21:18   ` Bruno Haible
2019-10-13 21:31     ` Assaf Gordon
2019-10-13 21:40       ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4073770.ak1ocBl5qt@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).