From: Collin Funk <collin.funk1@gmail.com>
To: bug-gnulib@gnu.org
Subject: gnulib-tool.py: Remove some unused instance variables.
Date: Fri, 26 Apr 2024 02:04:04 -0700 [thread overview]
Message-ID: <3a08c490-9ab7-43ca-8755-b9b703929190@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
Most of the instance variables in GLMegaTestDir are unused. This makes
sense since GLMegaTestDir pretty much just calls GLTestDir functions
on a list of modules and then does some extra work afterwards.
I committed this patch removing them.
Collin
[-- Attachment #2: 0001-gnulib-tool.py-Remove-some-unused-instance-variables.patch --]
[-- Type: text/x-patch, Size: 1684 bytes --]
From f306be627b5b2a45b829c9a7cb406c20d4d35198 Mon Sep 17 00:00:00 2001
From: Collin Funk <collin.funk1@gmail.com>
Date: Fri, 26 Apr 2024 01:58:09 -0700
Subject: [PATCH] gnulib-tool.py: Remove some unused instance variables.
* pygnulib/GLTestDir.py (GLMegaTestDir.__init__): Don't define instance
variables that are never used.
---
ChangeLog | 6 ++++++
pygnulib/GLTestDir.py | 4 ----
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 276258b885..4a2f0601bb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-04-26 Collin Funk <collin.funk1@gmail.com>
+
+ gnulib-tool.py: Remove some unused instance variables.
+ * pygnulib/GLTestDir.py (GLMegaTestDir.__init__): Don't define instance
+ variables that are never used.
+
2024-04-25 Collin Funk <collin.funk1@gmail.com>
gnulib-tool.py: Reduce code duplication in file name transformations.
diff --git a/pygnulib/GLTestDir.py b/pygnulib/GLTestDir.py
index 8534e19254..758a65168e 100644
--- a/pygnulib/GLTestDir.py
+++ b/pygnulib/GLTestDir.py
@@ -861,11 +861,7 @@ def __init__(self, config: GLConfig, megatestdir: str) -> None:
os.mkdir(self.megatestdir)
except Exception as exc:
raise GLError(19, self.megatestdir) from exc
- self.emitter = GLEmiter(self.config)
- self.filesystem = GLFileSystem(self.config)
self.modulesystem = GLModuleSystem(self.config)
- self.assistant = GLFileAssistant(self.config)
- self.makefiletable = GLMakefileTable(self.config)
def execute(self) -> None:
'''Create a mega scratch package with the given modules one by one
--
2.44.0
next reply other threads:[~2024-04-26 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 9:04 Collin Funk [this message]
2024-04-26 9:20 ` gnulib-tool.py: Remove some unused instance variables Bruno Haible
2024-04-26 9:37 ` Collin Funk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a08c490-9ab7-43ca-8755-b9b703929190@gmail.com \
--to=collin.funk1@gmail.com \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).