From: Sam James <sam@gentoo.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Peter Frazier <mrpeterfrazier@gmail.com>, bug-gnulib@gnu.org
Subject: Re: coreutils/gnulib - fts.c dangling pointers & gcc 13.1
Date: Sat, 4 Feb 2023 20:23:04 +0000 [thread overview]
Message-ID: <3CF19D45-F152-41AF-BFA9-0FB7A4B799DB@gentoo.org> (raw)
In-Reply-To: <456afa7c-fafc-dd20-af7e-8202aa24a6ad@cs.ucla.edu>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
> On 4 Feb 2023, at 20:20, Paul Eggert <eggert@cs.ucla.edu> wrote:
>
> On 2023-02-04 11:53, Sam James wrote:
>> I'd consider using #pragma GCC ... to suppress -Wuse-after-free
>> for the "problematic" lines instead. It'd avoid the risk of either optimisations or sanitisers
>> respectively causing us pain in future.
>
> I don't see why that pragma would avoid those problems. All it would do is shut off the warnings; GCC's underlying analyses would be the same, and GCC would generate the same machine code. In that sense these warnings are useful - they're canaries in the coal mine.
I guess it's hard for me to say given I don't know what options allowed it to be reproduced and I couldn't hit it.
I assumed it must have been -Wstrict-aliasing=2 or lower which makes it more aggressive at the risk of false positives.
But if you reproduced it, then it's useful, I suppose.
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]
next prev parent reply other threads:[~2023-02-04 20:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 20:24 coreutils/gnulib - fts.c dangling pointers & gcc 13.1 Peter Frazier
2023-02-03 22:11 ` Paul Eggert
2023-02-04 16:14 ` Sam James
2023-02-04 18:46 ` Paul Eggert
2023-02-04 19:53 ` Sam James
2023-02-04 20:20 ` Paul Eggert
2023-02-04 20:23 ` Sam James [this message]
2023-02-04 22:03 ` Paul Eggert
2023-02-04 22:10 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CF19D45-F152-41AF-BFA9-0FB7A4B799DB@gentoo.org \
--to=sam@gentoo.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=mrpeterfrazier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).