From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BCCAF1F47C for ; Sat, 14 Jan 2023 17:07:53 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=oRR0zOP2; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGk0H-0003r4-En; Sat, 14 Jan 2023 12:07:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGk0F-0003qI-PW for bug-gnulib@gnu.org; Sat, 14 Jan 2023 12:07:35 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGk0D-0006IB-C3 for bug-gnulib@gnu.org; Sat, 14 Jan 2023 12:07:35 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1673716046; cv=none; d=strato.com; s=strato-dkim-0002; b=EDPkC8Fe8nlF4TQDgtC0othOlkLa66SPyyx8VKHDz/HEjog8bwgD2j9dOk5maysbTD DXjm90qF0RXZydtWcqVAgHcMRC6/+htlrhh/2SoOzsEwdC7xiS6yB+ndny02mphVgWRj 8sy+BCjVQrkpZU5A83s3rDBWQAnanVkli2HrgOKk0v0WxymKPCdpyJkkDRBq8pUZ6TPU yob4pYU8lwb6l0pduAEA2QdFE87ktjWntxyXMSMB4Isxf77r56cYmLTLuPWg0JcQYzWJ rgYqyvvEvDcdJnDRWJMNLyXJskLFwjkGs3qh5aIyYw+0UGG/AEeBSmzzLBscXvV0QDO6 5RHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1673716046; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=VFqx1AThmzo32uv1ytb8Oq8/R08tjyq4W7yF1Hty/UY=; b=cFiI9oqR/a4UIZNRtqUWGWZGdLlbE/39d9ndwysjWzE+GB3q2LHbgYYCx3YXbIUn0O bLPYBmcjHVxMrihYxnyt5552Y7kF0g64D1FeHqDGi3hWBxrUUdlj0DlzM6fU8JAa1c0e RoKQqwIwVt90emnryj6B6Xd0FlgDR6IIuGivtwpMvj1cw8BsuLYGQ/RFSJrmNS5tTW1E nk3lEfR8kg7NBzWIErRQqoF60+yaVnElFGf577kSVhxZuxi1VmXCoGkmablSxyvJRzKX mGRHBMlR5aYbUi2q6xjexzpKLbFFWnY4Xy97J7gAcdPSlQkbWycEQ91Yti/a1NqMEfTc Yvpg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1673716046; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=VFqx1AThmzo32uv1ytb8Oq8/R08tjyq4W7yF1Hty/UY=; b=oRR0zOP2s4AMBZNtLnUrr/5S48dzwnGrydodMhAkL6TFZGDBsZKOSgQohH8cTL7H9S gBoxSLLfaIyxmN4Z5imR4WJ1IBPyul2I/Qa/7iTKq7gTcDNEZxQ34tTryzm/sdDukaYU Z/I+Iua2upWzG6vkUEBhoYlfe59UweOimVvxpegu71AXT2+GNERiX8wPjiCqFRsDAsbD EIfXHFZskEJBUNMTAXNUBJW2B4UbXFNDx1YibOwhqgnoZH1A1NLCIzdL+ptjUSnptHWi rH+Wg1XMyGRys/Fygd4+an3shU9348IyicCVKTkFqrjiBgM1DqwBQxTej5e45uVS+AO/ A0kA== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOSjfw0m4uruXlh4Gg94mBBqhqR" Received: from nimes.localnet by smtp.strato.de (RZmta 48.6.2 AUTH) with ESMTPSA id I8f358z0EH7QFhE (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sat, 14 Jan 2023 18:07:26 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Cc: Po Lu Subject: Re: fpending Android bug Date: Sat, 14 Jan 2023 18:07:26 +0100 Message-ID: <3831502.h0BymrIErR@nimes> In-Reply-To: <87wn5pb3dv.fsf@yahoo.com> References: <87wn5pb3dv.fsf.ref@yahoo.com> <87wn5pb3dv.fsf@yahoo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.161; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Hi Po Lu, > I think I now have the right fix for the fpending bug on Android. Before we make any change, we need to know what is wrong, i.e. what is "the fpending bug on Android". You haven't said so, after I asked in Please be specific: What do you mean by "not works"? Does not compile? Does not return which value? > diff --git a/xcompile/lib/fpending.c b/xcompile/lib/fpending.c > index afa840b8512..e57155e586e 100644 > --- a/xcompile/lib/fpending.c > +++ b/xcompile/lib/fpending.c > @@ -41,7 +41,7 @@ __fpending (FILE *fp) > return fp->_IO_write_ptr - fp->_IO_write_base; > #elif defined __sferror || defined __DragonFly__ || defined __ANDROID__ > /* FreeBSD, NetBSD, OpenBSD, DragonFly, Mac OS X, Cygwin < 1.7.34, Minix 3, Android */ > - return fp->_p - fp->_bf._base; > + return fp_->_p - fp_->_bf._base; > #elif defined __EMX__ /* emx+gcc */ > return fp->_ptr - fp->_buffer; > #elif defined __minix /* Minix */ IMO, this patch is a no-op: - If you are using an Android NDK older than r14b, the definition of 'struct __sFILE' is directly in and thus visible. - If you are using an Android NDK r14b or newer, with __ANDROID_API__ being < 24, the definition of 'struct __sFILE' has been moved out to but is still included from and is thus visible. - If you are using an Android NDK with __ANDROID_API__ being >= 23, the function __fpending exists and is declared, and therefore the Gnulib m4/fpending.m4 arranges to not compile fpending.c. So, in order to investigate this, you need to - explain what you meant by "not works", - run your configure script with option -C, - report the results of grep -i fpending config.cache and grep -i fpending config.status - say which NDK version you're using, - say what is the __ANDROID_API__ value in your environment. Bruno