Issue when testing with --as-needed enabled

Issue when testing with --as-needed enabled

[Thomas Andrejak]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Hello

Few years ago, we had an issue when--as-needed was enabled. There has been
a patch for this :
https://github.com/coreutils/gnulib/commit/426320901d46b1f3b63ba1ec8e9e60cb0e28cb77

But, event with this patch, I still have build failure and I need to do
some patches like that :
https://salsa.debian.org/totol-guest/libprelude/-/blob/master/debian/patches/013-fix-test_rwlock1.patch

I don't know how to dig on this bug.

Output :
FAIL: test-rwlock1
==================
Unexpected outcome 3
FAIL test-rwlock1 (exit status: 134)

Can someone help me on this ?

Thanks

Regards

[-- Attachment #2: Type: text/html, Size: 1078 bytes --]

Re: Issue when testing with --as-needed enabled

[Bruno Haible]

Thomas Andrejak wrote:
> Few years ago, we had an issue when--as-needed was enabled. There has been
> a patch for this :
> https://github.com/coreutils/gnulib/commit/426320901d46b1f3b63ba1ec8e9e60cb0e28cb77
> 
> But, event with this patch, I still have build failure and I need to do
> some patches like that :
> https://salsa.debian.org/totol-guest/libprelude/-/blob/master/debian/patches/013-fix-test_rwlock1.patch
> 
> I don't know how to dig on this bug.
> 
> Output :
> FAIL: test-rwlock1
> ==================
> Unexpected outcome 3
> FAIL test-rwlock1 (exit status: 134)
> 
> Can someone help me on this ?

On which OS (distro) do you see this? I'm asking because different distros
have configured GCC differently, and these are the details that matter
regarding --as-needed.

Bruno

Re: Issue when testing with --as-needed enabled

[Thomas Andrejak]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

Hello

Thanks for your answer

On debian 9 /10 / testing

Regards

Le ven. 27 nov. 2020 à 21:34, Bruno Haible <bruno@clisp.org> a écrit :

> Thomas Andrejak wrote:
> > Few years ago, we had an issue when--as-needed was enabled. There has
> been
> > a patch for this :
> >
> https://github.com/coreutils/gnulib/commit/426320901d46b1f3b63ba1ec8e9e60cb0e28cb77
> >
> > But, event with this patch, I still have build failure and I need to do
> > some patches like that :
> >
> https://salsa.debian.org/totol-guest/libprelude/-/blob/master/debian/patches/013-fix-test_rwlock1.patch
> >
> > I don't know how to dig on this bug.
> >
> > Output :
> > FAIL: test-rwlock1
> > ==================
> > Unexpected outcome 3
> > FAIL test-rwlock1 (exit status: 134)
> >
> > Can someone help me on this ?
>
> On which OS (distro) do you see this? I'm asking because different distros
> have configured GCC differently, and these are the details that matter
> regarding --as-needed.
>
> Bruno
>
>

[-- Attachment #2: Type: text/html, Size: 1747 bytes --]

Re: Issue when testing with --as-needed enabled

[Thomas Andrejak]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

Hello

Can you explain what GCC options can interfere with this ?

Thanks

Regards

Le dim. 29 nov. 2020 à 00:18, Thomas Andrejak <thomas.andrejak@gmail.com> a
écrit :

> Hello
>
> Thanks for your answer
>
> On debian 9 /10 / testing
>
> Regards
>
> Le ven. 27 nov. 2020 à 21:34, Bruno Haible <bruno@clisp.org> a écrit :
>
>> Thomas Andrejak wrote:
>> > Few years ago, we had an issue when--as-needed was enabled. There has
>> been
>> > a patch for this :
>> >
>> https://github.com/coreutils/gnulib/commit/426320901d46b1f3b63ba1ec8e9e60cb0e28cb77
>> >
>> > But, event with this patch, I still have build failure and I need to do
>> > some patches like that :
>> >
>> https://salsa.debian.org/totol-guest/libprelude/-/blob/master/debian/patches/013-fix-test_rwlock1.patch
>> >
>> > I don't know how to dig on this bug.
>> >
>> > Output :
>> > FAIL: test-rwlock1
>> > ==================
>> > Unexpected outcome 3
>> > FAIL test-rwlock1 (exit status: 134)
>> >
>> > Can someone help me on this ?
>>
>> On which OS (distro) do you see this? I'm asking because different distros
>> have configured GCC differently, and these are the details that matter
>> regarding --as-needed.
>>
>> Bruno
>>
>>

[-- Attachment #2: Type: text/html, Size: 2295 bytes --]

Re: Issue when testing with --as-needed enabled

[Thomas Andrejak]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

Hello

Does someone has any updates on this ?

Thanks

Regards

Le mar. 1 déc. 2020 à 13:56, Thomas Andrejak <thomas.andrejak@gmail.com> a
écrit :

> Hello
>
> Can you explain what GCC options can interfere with this ?
>
> Thanks
>
> Regards
>
> Le dim. 29 nov. 2020 à 00:18, Thomas Andrejak <thomas.andrejak@gmail.com>
> a écrit :
>
>> Hello
>>
>> Thanks for your answer
>>
>> On debian 9 /10 / testing
>>
>> Regards
>>
>> Le ven. 27 nov. 2020 à 21:34, Bruno Haible <bruno@clisp.org> a écrit :
>>
>>> Thomas Andrejak wrote:
>>> > Few years ago, we had an issue when--as-needed was enabled. There has
>>> been
>>> > a patch for this :
>>> >
>>> https://github.com/coreutils/gnulib/commit/426320901d46b1f3b63ba1ec8e9e60cb0e28cb77
>>> >
>>> > But, event with this patch, I still have build failure and I need to do
>>> > some patches like that :
>>> >
>>> https://salsa.debian.org/totol-guest/libprelude/-/blob/master/debian/patches/013-fix-test_rwlock1.patch
>>> >
>>> > I don't know how to dig on this bug.
>>> >
>>> > Output :
>>> > FAIL: test-rwlock1
>>> > ==================
>>> > Unexpected outcome 3
>>> > FAIL test-rwlock1 (exit status: 134)
>>> >
>>> > Can someone help me on this ?
>>>
>>> On which OS (distro) do you see this? I'm asking because different
>>> distros
>>> have configured GCC differently, and these are the details that matter
>>> regarding --as-needed.
>>>
>>> Bruno
>>>
>>>

[-- Attachment #2: Type: text/html, Size: 2822 bytes --]

Re: Issue when testing with --as-needed enabled

[Bruno Haible]

Hi,

Thomas Andrejak wrote:
> On debian 9 /10 / testing
> ...
> > > But, event with this patch, I still have build failure and I need to do
> > > some patches like that :
> > >
> > https://salsa.debian.org/totol-guest/libprelude/-/blob/master/debian/patches/013-fix-test_rwlock1.patch
> > >
> > > I don't know how to dig on this bug.
> > >
> > > Output :
> > > FAIL: test-rwlock1
> > > ==================
> > > Unexpected outcome 3
> > > FAIL test-rwlock1 (exit status: 134)

I cannot reproduce this. I took a Debian 10.7 distribution, with gcc-8 as
compiler package. I created a testdir for all of gnulib. I configured it
in 3 ways:
  - the normal way,
  - with LDFLAGS="... -Wl,--as-needed"
  - with CFLAGS="... -Wl,--as-needed"
and in all cases the build succeeded and all tests passed.

So, you need to give *precise* instructions for how to reproduce it.

Without reproducing, no one can give an analysis nor a fix.

Bruno

Re: Issue when testing with --as-needed enabled

[Thomas Andrejak]

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

Hello

I'm sorry, I was not on the master branch. With an up to date gnulib
version, I do not have this issue anymore.

Thanks !

Regards

Le dim. 3 janv. 2021 à 23:34, Bruno Haible <bruno@clisp.org> a écrit :

> Hi,
>
> Thomas Andrejak wrote:
> > On debian 9 /10 / testing
> > ...
> > > > But, event with this patch, I still have build failure and I need to
> do
> > > > some patches like that :
> > > >
> > >
> https://salsa.debian.org/totol-guest/libprelude/-/blob/master/debian/patches/013-fix-test_rwlock1.patch
> > > >
> > > > I don't know how to dig on this bug.
> > > >
> > > > Output :
> > > > FAIL: test-rwlock1
> > > > ==================
> > > > Unexpected outcome 3
> > > > FAIL test-rwlock1 (exit status: 134)
>
> I cannot reproduce this. I took a Debian 10.7 distribution, with gcc-8 as
> compiler package. I created a testdir for all of gnulib. I configured it
> in 3 ways:
>   - the normal way,
>   - with LDFLAGS="... -Wl,--as-needed"
>   - with CFLAGS="... -Wl,--as-needed"
> and in all cases the build succeeded and all tests passed.
>
> So, you need to give *precise* instructions for how to reproduce it.
>
> Without reproducing, no one can give an analysis nor a fix.
>
> Bruno
>
>

[-- Attachment #2: Type: text/html, Size: 1945 bytes --]

Re: Issue when testing with --as-needed enabled

[Jeffrey Walton]

On Tue, Dec 1, 2020 at 7:56 AM Thomas Andrejak
<thomas.andrejak@gmail.com> wrote:
>
> Can you explain what GCC options can interfere with this ?

--as-needed caused problems in the past. I think it was a linker bug.
On occasion you needed to tame the linker with -Wl,--no-as-needed. The
weird thing was, the need for -Wl,--no-as-needed was intermittent.

Aslo see http://gcc.1065356.n8.nabble.com/g-Wl-as-needed-pthread-behaviour-td970392.html.

Jeff