From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id CD0E01F47C for ; Wed, 4 Jan 2023 11:28:29 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=WmLcSoRX; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pD1wL-0003iX-5T; Wed, 04 Jan 2023 06:28:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD1wJ-0003i6-Ig for bug-gnulib@gnu.org; Wed, 04 Jan 2023 06:28:11 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pD1wH-0001qQ-CW for bug-gnulib@gnu.org; Wed, 04 Jan 2023 06:28:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1672831678; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=r59t6onjIRX9KaQyjIcxNDdN1ZWCk4VC/03jzEkWPdw=; b=WmLcSoRXjynBwgTZ0u7j6ZnR4emN3KmHoPg2Njf1sSEs8i6Up1KyrQT+BGNzTFcLYF yaXevsSM1/qPgX8uh+Qe3N2Y4J9NUUiyuPCIvjswQVkydjQfIBU/ikGywETEdiRnDwty IeDeqlDtpgVcZcKy6bayQfc8hz//7mlhqN8CzpT9qCrxkjULmhMfO29HybS9VfZMbbjU 7zjpuS/FpQ0s8XOOFfGud7leQcxOZC0VNxqljTNGrXa8YPZ8bqFkt3agv5u5G9fTB0p+ 0r0qbQL+DMCvvpwNvgEjzcfzoR2JkIZMEL3hWy+IDR2FDf0ACTVYeuaNPmRBJ60H6F5a gxYA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOX2vdClfEwFaPfEGVf28qrkcyD5w==" X-RZG-CLASS-ID: mo00 Received: from nimes.localnet by smtp.strato.de (RZmta 48.2.1 AUTH) with ESMTPSA id t05890z04BRv4nS (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 4 Jan 2023 12:27:57 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org, Ondrej Valousek Cc: kdudka@redhat.com Subject: Re: [PATCH] Use xattr (Linux) in copy-acl.c Date: Wed, 04 Jan 2023 12:27:57 +0100 Message-ID: <3727963.L4jQFfv3LO@nimes> In-Reply-To: <20230104100328.1215830-1-ondrej.valousek.xm@renesas.com> References: <20230104100328.1215830-1-ondrej.valousek.xm@renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=85.215.255.25; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Ondrej Valousek wrote: > Hope it looks fine now. This looks better indeed. > +#ifdef USE_XATTR Since USE_XATTR is always defined (to 0 or 1), you need to test it with #if, not #ifdef. > @@ -42,10 +56,29 @@ qcopy_acl (const char *src_name, int source_desc, con= st char *dst_name, > struct permission_context ctx; This variable is only used in the #else case. To avoid compiler warnings (I hope you always test with -Wall, right?) this variable declaration should be moved into the #else block. > + AC_SUBST([LIB_XATTR]) I don't see any use of $(LIB_XATTR) so far. AFAICS, it ought to be used - in the 'Link' section of modules/qcopy-acl, - in the 'Link' section of modules/acl, modules/copy-file, modules/qacl, modules/supersede =E2=80=94 since these modules depend on qcopy-acl. - for the programs created in modules/acl-tests, modules/copy-file-tests, modules/supersede-tests. Preferably each time right after $(LIB_ACL). (One needs to lists the libraries explicitly, because you have no guarantee that the distro uses shared libraries with implicit dependencies. It could also be shared libraries without explicit dependencies, or static libraries= =2E) Bruno