bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Collin Funk <collin.funk1@gmail.com>
To: bug-gnulib@gnu.org
Subject: Can we have gnulib-tool.py emit the same copyright header?
Date: Tue, 27 Feb 2024 17:41:51 -0800	[thread overview]
Message-ID: <36e3772e-7225-45e9-a2b4-3ea1f5405519@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]

When creating a Makefile for example, the diff between gnulib-tool and
gnulib-tool.py is:

diff --git a/lib/gnulib.mk.in b/lib/gnulib.mk.in
index a718c17c0e8..15d15970051 100644
--- a/lib/gnulib.mk.in
+++ b/lib/gnulib.mk.in
@@ -1,5 +1,5 @@
 ## DO NOT EDIT! GENERATED AUTOMATICALLY!
-# Copyright (C) 2002-2024 Free Software Foundation, Inc.
+# Copyright (C) 2024 Free Software Foundation, Inc.

The gnulib-tool.py one only does a single year instead of the range.

This diff is copied from the attached patch:

diff --git a/pygnulib/GLInfo.py b/pygnulib/GLInfo.py
index 808f11b06f..1759368268 100644
--- a/pygnulib/GLInfo.py
+++ b/pygnulib/GLInfo.py
@@ -80,8 +80,6 @@ class GLInfo(object):
         '''Return formatted string which contains copyright.
         The special __copyright__ variable is used (type is str).'''
         copyright = __copyright__
-        # Per the GNU Coding Standards, show only the last year.
-        copyright = re.compile('^[0-9]*-').sub('', copyright)
         result = 'Copyright (C) %s' % copyright
         return result

The GNU Maintainer guide seems to disagree with this comment (assuming
that gnulib-tool.py is not a separate package) [1]. Am I missing
something or can we make this change?

[1] https://www.gnu.org/prep/maintain/maintain.html#Copyright-Notices

Thanks,
Collin

[-- Attachment #2: 0001-gnulib-tool.py-Emit-copyright-notices-as-a-year-rang.patch --]
[-- Type: text/x-patch, Size: 1441 bytes --]

From 202d152d8a0a6fa3875c44ff5cd38bdd4b0d485d Mon Sep 17 00:00:00 2001
From: Collin Funk <collin.funk1@gmail.com>
Date: Tue, 27 Feb 2024 17:30:18 -0800
Subject: [PATCH] gnulib-tool.py: Emit copyright notices as a year range.

* pygnulib/GLInfo.py (GLInfo.copyright): Fix copyright string. Remove
comment to reflect change.
---
 ChangeLog          | 6 ++++++
 pygnulib/GLInfo.py | 2 --
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index af3af3707e..84f5bcee88 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-02-27  Collin Funk  <collin.funk1@gmail.com>
+
+	gnulib-tool.py: Emit copyright notices as a year range.
+	* pygnulib/GLInfo.py (GLInfo.copyright): Fix copyright string. Remove
+	comment to reflect change.
+
 2024-02-27  Bruno Haible  <bruno@clisp.org>
 
 	isnan: Fix compilation error in C++ mode on OpenBSD 7.5-beta.
diff --git a/pygnulib/GLInfo.py b/pygnulib/GLInfo.py
index 808f11b06f..1759368268 100644
--- a/pygnulib/GLInfo.py
+++ b/pygnulib/GLInfo.py
@@ -80,8 +80,6 @@ class GLInfo(object):
         '''Return formatted string which contains copyright.
         The special __copyright__ variable is used (type is str).'''
         copyright = __copyright__
-        # Per the GNU Coding Standards, show only the last year.
-        copyright = re.compile('^[0-9]*-').sub('', copyright)
         result = 'Copyright (C) %s' % copyright
         return result
 
-- 
2.39.2


             reply	other threads:[~2024-02-28  1:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28  1:41 Collin Funk [this message]
2024-02-28  2:07 ` Can we have gnulib-tool.py emit the same copyright header? Bruno Haible
2024-02-28  2:19   ` Collin Funk
2024-02-28  2:26     ` Bruno Haible
2024-02-28  2:51       ` Collin Funk
2024-02-28  7:53         ` Collin Funk
2024-02-28 11:00           ` Bruno Haible
2024-02-28 21:18             ` Collin Funk
2024-02-28 21:30               ` Bruno Haible
2024-02-28 21:48                 ` Collin Funk
2024-02-28 23:34                   ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36e3772e-7225-45e9-a2b4-3ea1f5405519@gmail.com \
    --to=collin.funk1@gmail.com \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).