From: Paul Eggert <eggert@cs.ucla.edu>
To: KO Myung-Hun <komh78@gmail.com>
Cc: bug-gnulib@gnu.org
Subject: Re: [PATCH] binary-io: do not treat set_binary_mode() on stdin/out/err as an error on OS/2
Date: Fri, 24 May 2019 13:20:46 -0700 [thread overview]
Message-ID: <3639ab4a-d9c2-b239-906d-9f9ac2fa8601@cs.ucla.edu> (raw)
In-Reply-To: <20190524113138.34458-1-komh@chollian.net>
On 5/24/19 4:31 AM, KO Myung-Hun wrote:
> Setting stdin/out/err to binary mode is allowed on OS/2. But it's not
> useful, because it generates stair-output hard to read.
>
> Instead, let's set them to text mode all the time.
First, that patch doesn't set them to text mode all the time; it does so
only if isatty returns nonzero.
Second, __gl_setmode_check already has the isatty test, so why do it twice?
next prev parent reply other threads:[~2019-05-24 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 11:31 [PATCH] binary-io: do not treat set_binary_mode() on stdin/out/err as an error on OS/2 KO Myung-Hun
2019-05-24 20:20 ` Paul Eggert [this message]
2019-05-25 3:29 ` KO Myung-Hun
2019-05-25 13:41 ` Bruno Haible
2019-05-25 14:18 ` KO Myung-Hun
2019-05-25 16:31 ` Bruno Haible
2019-05-25 17:14 ` Paul Eggert
2019-05-26 1:48 ` KO Myung-Hun
2019-05-29 0:47 ` Bruno Haible
2019-05-29 13:32 ` KO Myung-Hun
2019-05-30 0:05 ` Paul Eggert
2019-05-30 0:55 ` Bruno Haible
2019-06-02 6:03 ` Paul Eggert
2019-06-02 9:31 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3639ab4a-d9c2-b239-906d-9f9ac2fa8601@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=bug-gnulib@gnu.org \
--cc=komh78@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).