From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 289B91F47C for ; Wed, 25 Jan 2023 08:44:17 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=JSdtoCwX; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKbO8-0001MU-Dn; Wed, 25 Jan 2023 03:44:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKbO6-0001MH-2Q for bug-gnulib@gnu.org; Wed, 25 Jan 2023 03:44:10 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKbO3-0007i2-Af for bug-gnulib@gnu.org; Wed, 25 Jan 2023 03:44:09 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1674636242; cv=none; d=strato.com; s=strato-dkim-0002; b=bhn7NHGfvkFcKrMcOMwupqbyw4zzIsO9N+ejuP03NAFiReogw3B+Gu1rIpxDXg4dXm 0A3MOdQgRWzIarw1LWtCJXZ4+qHnbSYaf9ZPJMkHDyov7wc4KE0aDkDC6v3A591da8rn maBGxfh0PXLMdJCgIMsGQ65WqlpUMivrdlaJsjIq4BCSOSBZaIRICXHzwqHVZG1uJkXi CiE8l02VzcQ0wzWOva0L9UF9hXcEB4aSNVPjmCEvf+UzBH18SFdd903LF7W9oruIUj5i AN6fF3pxoS2TPslIHeu9Sn5AzgZOcti29maJqNR2/rkenhyglXE8psMiCsSj3MQNVOjh q59A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1674636242; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=dBRseJ7YZ8JwncHWkXp0KNudRHx4TmpV01qofFp2FDg=; b=Qk7QvvxgDlu+nrFCf80g515lQ7QTTQCpi9rStncimWyQWMlX4OdhO5EY2B5s3Ng4EK N4nk83enk/CyA6HvwrQ5KacFU5WYtMLBU7QDWcwbWBI2imErt/hU+5YE+VC9hSjuWnRQ cUZCGE9mcsGlrk2kBsl803iO8IW0YWehP5o4UnmId31eIgeE8BYdiE6Azys8izP0UQB9 3a8KCKY5R/ZWTZnvM9+GBrXLBq63djWwSqmxdkDZG03lYD6CtUmXLHn1mlCidMbO2fKf WvnCULi9NPkvB+hLmFxVcdSxGm+gwoRvbzlfMveGHCaM2lJ6eSRhB2VUeqJ9DHBjm/Ti gPpA== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1674636242; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=dBRseJ7YZ8JwncHWkXp0KNudRHx4TmpV01qofFp2FDg=; b=JSdtoCwXkyoONnPkWt82ZCsQhziChT61qFhIc1DsZ6gArdHwiTfew/NSatfVtCKIf1 KaeKVKg+1FDKqG3abTwOgmSMaqcrvHO/iaoTXwWoIjzExGC208iBtO7TcgxtcYp27k3r pnGA/IY2AspPNtuLoLmAaI7kTa5uVKGd0Xb0bvnwkUtK4C4Ph5Bnwxp8zclwmvScL2Hc dJzMiLlH41fIJOOPZ3byZVWaZqIoV7vF52TEYzOLc4IibHA1/HR27SyLwQnpqcMmof1R tJU3m9QB4GMH28JfTSrCvaJv+wU1WZHsAKHgFP7YDePSgXcCQgTleVjtmOVNG0yaODy9 6v8A== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOfjvdojYPtA21VstjeqKl4wVZ9" Received: from nimes.localnet by smtp.strato.de (RZmta 49.2.2 AUTH) with ESMTPSA id 098542z0P8i26Cd (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 25 Jan 2023 09:44:02 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Cc: Nick Bowler Subject: Re: [PATCH] threadlib: fix case patterns for older Solaris. Date: Wed, 25 Jan 2023 09:44:01 +0100 Message-ID: <3615681.V0PKsyC1H6@nimes> In-Reply-To: <20230125035345.26562-1-nbowler@draconx.ca> References: <20230125035345.26562-1-nbowler@draconx.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.163; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Hi, Nick Bowler wrote: > The case pattern which matches solaris2.[1-9] etc. is not fully > quoted, so the brackets get eaten by m4 and don't actually make > it into the resulting configure script, giving just: > > case "$host_os" in > solaris | solaris2.1-9 | solaris2.1-9.* | hpux*) > > which is obviously not correct. Oh, indeed! Thanks for the observation and the fix. I have applied it in your name. (The "tiny change" marker in the ChangeLog merely means that the change is small enough that I could apply it without asking you for a copyright assignment. Cf. https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html .) > * m4/threadlib.m4 (gl_STDTHREADLIB_BODY): Allow case patterns to > survive m4 processing by using changequote. The change was in gl_PTHREADLIB_BODY, not in gl_STDTHREADLIB_BODY. But anyway, thanks for providing the change description in the first place. Bruno 2023-01-25 Nick Bowler (tiny change) threadlib: Fix support for Solaris 9 and older. * m4/threadlib.m4 (gl_PTHREADLIB_BODY): Allow case patterns to survive m4 processing by using changequote. diff --git a/m4/threadlib.m4 b/m4/threadlib.m4 index 48ced460b3..7202b9528d 100644 --- a/m4/threadlib.m4 +++ b/m4/threadlib.m4 @@ -1,4 +1,4 @@ -# threadlib.m4 serial 34 +# threadlib.m4 serial 35 dnl Copyright (C) 2005-2023 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -261,7 +261,9 @@ AC_DEFUN([gl_PTHREADLIB_BODY], # On Solaris 10 or newer, this test is no longer needed, because # libc contains the fully functional pthread functions. case "$host_os" in +changequote(,)dnl solaris | solaris2.[1-9] | solaris2.[1-9].* | hpux*) +changequote([,])dnl AC_DEFINE([PTHREAD_IN_USE_DETECTION_HARD], [1], [Define if the pthread_in_use() detection is hard.]) esac