bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Nick Bowler <nbowler@draconx.ca>
Subject: Re: [PATCH] threadlib: fix case patterns for older Solaris.
Date: Wed, 25 Jan 2023 09:44:01 +0100	[thread overview]
Message-ID: <3615681.V0PKsyC1H6@nimes> (raw)
In-Reply-To: <20230125035345.26562-1-nbowler@draconx.ca>

Hi,

Nick Bowler wrote:
> The case pattern which matches solaris2.[1-9] etc. is not fully
> quoted, so the brackets get eaten by m4 and don't actually make
> it into the resulting configure script, giving just:
> 
>     case "$host_os" in
>       solaris | solaris2.1-9 | solaris2.1-9.* | hpux*)
> 
> which is obviously not correct.

Oh, indeed! Thanks for the observation and the fix. I have applied
it in your name. (The "tiny change" marker in the ChangeLog merely
means that the change is small enough that I could apply it without
asking you for a copyright assignment. Cf.
https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html .)

> * m4/threadlib.m4 (gl_STDTHREADLIB_BODY): Allow case patterns to
> survive m4 processing by using changequote.

The change was in gl_PTHREADLIB_BODY, not in gl_STDTHREADLIB_BODY.
But anyway, thanks for providing the change description in the
first place.

Bruno


2023-01-25  Nick Bowler  <nbowler@draconx.ca>  (tiny change)

	threadlib: Fix support for Solaris 9 and older.
	* m4/threadlib.m4 (gl_PTHREADLIB_BODY): Allow case patterns to survive
	m4 processing by using changequote.

diff --git a/m4/threadlib.m4 b/m4/threadlib.m4
index 48ced460b3..7202b9528d 100644
--- a/m4/threadlib.m4
+++ b/m4/threadlib.m4
@@ -1,4 +1,4 @@
-# threadlib.m4 serial 34
+# threadlib.m4 serial 35
 dnl Copyright (C) 2005-2023 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -261,7 +261,9 @@ AC_DEFUN([gl_PTHREADLIB_BODY],
              # On Solaris 10 or newer, this test is no longer needed, because
              # libc contains the fully functional pthread functions.
              case "$host_os" in
+changequote(,)dnl
                solaris | solaris2.[1-9] | solaris2.[1-9].* | hpux*)
+changequote([,])dnl
                  AC_DEFINE([PTHREAD_IN_USE_DETECTION_HARD], [1],
                    [Define if the pthread_in_use() detection is hard.])
              esac





      reply	other threads:[~2023-01-25  8:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25  3:53 [PATCH] threadlib: fix case patterns for older Solaris Nick Bowler
2023-01-25  8:44 ` Bruno Haible [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3615681.V0PKsyC1H6@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=nbowler@draconx.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).