From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D33291F453 for ; Mon, 11 Feb 2019 03:40:03 +0000 (UTC) Received: from localhost ([127.0.0.1]:43535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gt2Rs-00027Y-Ef for normalperson@yhbt.net; Sun, 10 Feb 2019 22:40:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gt2Ro-00027J-If for bug-gnulib@gnu.org; Sun, 10 Feb 2019 22:39:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gt2Rn-0001y7-KK for bug-gnulib@gnu.org; Sun, 10 Feb 2019 22:39:56 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::11]:17534) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gt2Rj-0001U7-Uq for bug-gnulib@gnu.org; Sun, 10 Feb 2019 22:39:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1549856359; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=TfSdrP5yXPHyMUFkN6LL8ADPgXPi+nHVJjL6g2bXLHw=; b=ok483hp5ZfcSYpWwCLusC8jBwTJ9QChTbQqe1XDxYV0PcrCgkU8Gxj9cBonKT8Jcy1 EGtNPde22oqX8y0iKAvDkx62xJbmgJky4C1ZRpqsoxC+9ioub/brlBPc1Cgb57tFBns5 jEGuzh02l6IdA7UlpQWkN73sERNrFxU/pR9JKF90OJ1KRvxHAcknuJFTevDuciiPXr6G G7DIKcQ1f8IxNYuvscQtCNAI9KEMT1HWIsSL8A07e0qzq9DGH2RoQuFb8IreANA3yHO/ HpbJovEYSny5aRSUXQl/rWZcmFnIOAwx4Eku8bDlgK17DYl9+xc03QYJvK9EJm7bIK1M DX4A== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGaf3zJZW" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH) with ESMTPSA id v0a34ev1B3dD2yi (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 11 Feb 2019 04:39:13 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: [PATCH] *-map, *-omap: Allow passing NULL to search Date: Mon, 11 Feb 2019 04:39:13 +0100 Message-ID: <3610240.7gtmQhBts7@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20190211023736.hrr4abkbfwqncb56@riva.ucam.org> References: <20190211002902.zeap3f6hrr6vb5fe@riva.ucam.org> <2481719.ubWUpSM3oy@omega> <20190211023736.hrr4abkbfwqncb56@riva.ucam.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::11 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Colin Watson Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi Colin, > > 2) Allowing NULL pointers as arguments in all possible places is > > *not* a good coding style in general. (It may be a good practice, > > though, when you're being paid for a consulting project and your > > code will never be maintained once you have delivered it.) > > I respect your opinion as the maintainer and if you don't want to > include this that's of course fine, but please could you refrain from > implying incompetence? It's not nice. I'm sorry that you understood it in that way. It was really not meant that way. I remember your name as a long-time serious contributor to various packages. It must be possible to talk about coding style and good/bad practices. Of course, what I said about these practices are _opinions_, and - Anyone can disagree with my opinions. - Opinions can change over time: You are showing that when I wrote the gl_list_iterator_next code, I apparently had a different opinion. - I do not even know whether you have the habit of allowing NULL arguments in general. Therefore I was not criticizing you; I was criticizing a certain aspect of the proposed patch. (Which is also what I constantly do before committing or submitting a patch myself: scrutinize it under aspects that, from experience, are known as good or bad practices.) The sentence about the consulting project was not about you as a person either; it was meant as a reflection about a condition when I would find it justified to employ that "bad" coding style myself. Can we be friends again? Bruno