bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: "Markus Mützel" <markus.muetzel@gmx.de>
Subject: Re: conflicting types in windows-spawn
Date: Fri, 14 May 2021 12:39:21 +0200	[thread overview]
Message-ID: <3258651.ffcNuEFZTC@omega> (raw)
In-Reply-To: <trinity-4c362363-abd7-4aad-bfd3-7d5ca6f4d01f-1620307501148@3c-app-gmx-bs65>

Hi,

Markus Mützel wrote:
> On second thought, the header should probably better not re-define STARTUPINFO.
> The following alternative change might be saver:
> 
> From 84df3e82f88799d211bd4f5147473b238937d458 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Markus=20M=C3=BCtzel?= <markus.muetzel@gmx.de>
> Date: Thu, 6 May 2021 15:20:30 +0200
> Subject: [PATCH] windows-spawn: Don't assume that UNICODE is not defined
> 
> * lib/windows-spawn.h: Use ANSI structure STARTUPINFOA.
> ---
>  lib/windows-spawn.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/windows-spawn.h b/lib/windows-spawn.h
> index 1c29d1b17..9bcfb1c82 100644
> --- a/lib/windows-spawn.h
> +++ b/lib/windows-spawn.h
> @@ -116,7 +116,7 @@ extern int init_inheritable_handles (struct inheritable_handles *inh_handles,
>     Returns 0 upon success.  In case of failure, -1 is returned, with errno set.
>   */
>  extern int compose_handles_block (const struct inheritable_handles *inh_handles,
> -                                  STARTUPINFO *sinfo);
> +                                  STARTUPINFOA *sinfo);
>  
>  /* Frees the memory held by a set of inheritable handles.  */
>  extern void free_inheritable_handles (struct inheritable_handles *inh_handles);
> 

Yes, I agree. That's the proper way to fix it. I applied and pushed your change.
Thanks!

Bruno



  reply	other threads:[~2021-05-14 10:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 12:28 conflicting types in windows-spawn Markus Mützel
2021-05-06 13:25 ` Markus Mützel
2021-05-14 10:39   ` Bruno Haible [this message]
2021-05-14 15:38     ` Markus Mützel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3258651.ffcNuEFZTC@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=markus.muetzel@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).