From: Bruno Haible <bruno@clisp.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: bug-gnulib@gnu.org
Subject: Re: Avoid clang warnings regarding [[__nodiscard__]]
Date: Sat, 28 Jan 2023 20:22:33 +0100 [thread overview]
Message-ID: <3200862.iN0EsnfWmB@nimes> (raw)
In-Reply-To: <0994b74a-97da-1650-3c21-00089936c24e@cs.ucla.edu>
Paul Eggert wrote:
> > + /* With clang up to 15.0.6 (at least), in C++ mode, [[__nodiscard__]] produces
> > + a warning. */
> > +# if __clang_major__ >= 1000
>
> I found this a little hard to follow
Indeed, I wondered whether I should add a comment. Guess I should have :)
> How about something like the attached, to simplify this for Clang non-experts?
I wanted the code to be prepared for the day when clang++ actually adds
support for this syntax [[__nodiscard__]]. The code you are proposing
optimizes the current needs, but not the future needs.
I'm adding this comment instead. I hope that's clear enough.
2023-01-28 Bruno Haible <bruno@clisp.org>
Clarify _GL_ATTRIBUTE_NODISCARD code.
Reported by Paul Eggert.
* m4/gnulib-common.m4 (gl_COMMON_BODY): Add comment regarding
_GL_ATTRIBUTE_NODISCARD definition.
diff --git a/m4/gnulib-common.m4 b/m4/gnulib-common.m4
index d632819864..c0181abdc5 100644
--- a/m4/gnulib-common.m4
+++ b/m4/gnulib-common.m4
@@ -381,7 +381,10 @@ AC_DEFUN([gl_COMMON_BODY], [
#ifndef _GL_ATTRIBUTE_NODISCARD
# if defined __clang__ && defined __cplusplus
/* With clang up to 15.0.6 (at least), in C++ mode, [[__nodiscard__]] produces
- a warning. */
+ a warning.
+ The 1000 below means a yet unknown threshold. When clang++ version X
+ starts supporting [[__nodiscard__]] without warning about it, you can
+ replace the 1000 with X. */
# if __clang_major__ >= 1000
# define _GL_ATTRIBUTE_NODISCARD [[__nodiscard__]]
# endif
prev parent reply other threads:[~2023-01-28 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 10:57 Avoid clang warnings regarding [[__nodiscard__]] Bruno Haible
2023-01-28 19:06 ` Paul Eggert
2023-01-28 19:22 ` Bruno Haible [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3200862.iN0EsnfWmB@nimes \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).