From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: sh-filename: Add support for Android
Date: Sat, 26 Jan 2019 15:43:10 +0100 [thread overview]
Message-ID: <3198734.lA0q7Mg682@omega> (raw)
On Android 4.3, I'm seeing these test failures:
FAIL: test-posix_spawn1
=======================
could not read expected output
FAIL test-posix_spawn1 (exit status: 1)
FAIL: test-posix_spawn2
=======================
subprocess terminated with unexpected exit status 127
FAIL test-posix_spawn2 (exit status: 1)
The cause is that these tests execute a shell script, and the shell
is not at /bin/sh in this environment.
This patch fixes it.
2019-01-26 Bruno Haible <bruno@clisp.org>
sh-filename: Add support for Android 4.3.
* m4/sh-filename.m4 (gl_SH_FILENAME): Set to "sh" on Android.
diff --git a/m4/sh-filename.m4 b/m4/sh-filename.m4
index 3e7fe75..dc5f26d 100644
--- a/m4/sh-filename.m4
+++ b/m4/sh-filename.m4
@@ -1,4 +1,4 @@
-# sh-filename.m4 serial 1
+# sh-filename.m4 serial 2
dnl Copyright (C) 2018-2019 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
@@ -10,9 +10,11 @@ AC_DEFUN([gl_SH_FILENAME],
[
AH_VERBATIM([SH_FILENAME],
[/* File name of the Bourne shell. */
-#if defined __CYGWIN__
-/* Omit the directory part because for 32-bit Cygwin programs in a
- 64-bit Cygwin environment, the Cygwin mounts are not visible. */
+#if defined __CYGWIN__ || defined __ANDROID__
+/* Omit the directory part because
+ - For 32-bit Cygwin programs in a 64-bit Cygwin environment, the Cygwin
+ mounts are not visible.
+ - On Android, /bin/sh does not exist. It's /system/bin/sh instead. */
# define BOURNE_SHELL "sh"
#else
# define BOURNE_SHELL "/bin/sh"
reply other threads:[~2019-01-26 14:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3198734.lA0q7Mg682@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).