bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org, Ondrej Valousek <ondrej.valousek.xm@renesas.com>
Subject: Re: [PATCH] Improve comments for [q]set-acl.c
Date: Tue, 17 Jan 2023 15:27:28 +0100	[thread overview]
Message-ID: <3149587.7fYK7mqo5U@nimes> (raw)
In-Reply-To: <20230117132833.1730306-1-ondrej.valousek.xm@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

Hi Ondrej,

> Hi Bruno, sorry, this patch should be fine now.

The patch applies, but it still introduces trailing spaces:
When I apply it I get

Applying: Improve comments for [q]set-acl.c
.git/rebase-apply/patch:23: trailing whitespace.
   ACLs. If DESC is a valid file descriptor, use file descriptor operations 
.git/rebase-apply/patch:24: trailing whitespace.
   where available, else use filename based operations on NAME.  If access 
.git/rebase-apply/patch:25: trailing whitespace.
   control lists are not available, fchmod the target file to MODE.  Also 
.git/rebase-apply/patch:26: trailing whitespace.
   sets the non-permission bits of the destination file 
.git/rebase-apply/patch:50: trailing whitespace.
   ACLs. If DESC is a valid file descriptor, use file descriptor operations 
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.

and when I then do "git diff HEAD~1 HEAD", I see the red markers.

Can you please deal with that before you send the patch? Thanks.

[-- Attachment #2: git-diff.png --]
[-- Type: image/png, Size: 48102 bytes --]

  reply	other threads:[~2023-01-17 14:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 13:28 [PATCH] Improve comments for [q]set-acl.c Ondrej Valousek
2023-01-17 14:27 ` Bruno Haible [this message]
     [not found] <20230117173117.1735089-1-ondrej.valousek.xm@renesas.com>
2023-01-17 18:33 ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3149587.7fYK7mqo5U@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=ondrej.valousek.xm@renesas.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).