From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 651E920248 for ; Fri, 15 Mar 2019 09:41:46 +0000 (UTC) Received: from localhost ([127.0.0.1]:52548 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4jLV-0000hg-2Y for normalperson@yhbt.net; Fri, 15 Mar 2019 05:41:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4jH9-0005km-2z for bug-gnulib@gnu.org; Fri, 15 Mar 2019 05:37:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4j4U-0004NV-D2 for bug-gnulib@gnu.org; Fri, 15 Mar 2019 05:24:11 -0400 Received: from mail-yw1-xc30.google.com ([2607:f8b0:4864:20::c30]:45828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4j4S-0004LJ-Fa for bug-gnulib@gnu.org; Fri, 15 Mar 2019 05:24:08 -0400 Received: by mail-yw1-xc30.google.com with SMTP id r188so6681332ywb.12 for ; Fri, 15 Mar 2019 02:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=iXdGLuugy8WfeE4/FEPedQAGUxmvEZcOA50KpSYcj+c=; b=VveB4Ltw2VVRJNddcFldG5PBMEsnzbgcT8/HIJZBm6F82rh3AahESAL9epiEodZ0wT NI9B/Oz+UxOcZ+jdxxrmJdcyVhrIUmgCumSYRGQRqGpNSzqfebNjUA3kGY4yloz6ZRlP aCWwkN2bPzazdKOVXAY8o0a/2YJgiaHfbPNeefHO3zdLPUC+r+oJHxP2vhLKOgeMBjMJ G2nJzB8lXTnjk/NiTARNll29Y3vCTHBvPZq3x77T+zOTQyDpqg+mLjXT3kvYhUNe6cob dmqReYdmaeiR2nUmN1wFLlbAxFtAqwVLvv+KNFWW9qxCaKdmP15BniYLIFP5CuqocNd6 cUlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iXdGLuugy8WfeE4/FEPedQAGUxmvEZcOA50KpSYcj+c=; b=fyQoBTRQIV9fGkTc72VTyi1IVRjDoWLjpK3rpUHOU3ZtinQbtS1XQgK6cpUEdddnu8 LBMR4X1ZPAAZWZxhhUdhGINTk9BDfOIIjDzdPS5uZJ/iFZQB+X3WzfD4gmvpu7K5dHUw OwVfGAdxaHXBE2YLK8CWknmceFwtusRZmqUeXBV1BNoOWebqVnS+9GOrBkcQH3WU4ckG eQRltS4X1m7Bxegr6nSqRC3oPnvlWsZlGZeFsIsVKkhb/rn63ShojtGctqvZvIwpm1LY 70FFGilFm1AX6ZuAp2YTQGq/wNq9N/uhjp5/h5QlbOJ1tZUI1qXXSK5eWJ0Euoud8ejT lHcQ== X-Gm-Message-State: APjAAAVTKyXduzKTbFu5j9lXf7nNb+8UkXBYX96eb427sSGYnC++lQVz vxw8lU2sX8UDG+ufLGlrfdRAGAFnJis= X-Google-Smtp-Source: APXvYqzuWEix3FZaveEr9JtW1/iZbc5K6PAYjfiN4o7Gu+PP3WIIr36oNBN+LmjqMzn/Tw+3tcTn/A== X-Received: by 2002:a25:4147:: with SMTP id o68mr2039704yba.410.1552641845924; Fri, 15 Mar 2019 02:24:05 -0700 (PDT) Received: from [100.64.66.41] (eth1.dop002.at1.hwcdn.net. [205.185.217.142]) by smtp.gmail.com with ESMTPSA id r5sm660995ywc.58.2019.03.15.02.24.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 02:24:05 -0700 (PDT) Subject: Re: isatty: make it return true in Cygwin consoles on native Windows To: bug-gnulib@gnu.org References: <2401179.5IOFXfDAMd@omega> From: Gisle Vanem Message-ID: <2c042666-bf3f-1096-29f6-991495613e46@gmail.com> Date: Fri, 15 Mar 2019 10:24:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <2401179.5IOFXfDAMd@omega> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::c30 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Bruno Haible wrote: > + if (QueryFullProcessImageNameFunc (processHandle, 0, buf, &bufsize)) > + { > + if (strlen (buf) >= 11 > + && strcmp (buf + strlen (buf) - 11, "\\mintty.exe") == 0) What if the .exe has another name? The purpose of your function looks similar to what Mihail Konev did for the MinGW-w64 project: https://mingw-w64-public.narkive.com/s7kYRrtG/patch-mingw-w64-add-include-iscygtty-c Instead he looked for pipes matching: "\Device\NamedPipe\(cygwin|msys)-[a-fA-F0-9]{16}-pty[0-9]{1,4}-(from-master|to-master|to-master-cyg)" BTW. I created my own version of in his work in my Envtool program. The 'is_cygwin_tty()' function: https://github.com/gvanem/EnvTool/blob/master/src/misc.c#L3918 -- --gv