From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6A6111F4B4 for ; Fri, 1 Jan 2021 12:57:04 +0000 (UTC) Received: from localhost ([::1]:35100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvJzL-0003Uf-3E for normalperson@yhbt.net; Fri, 01 Jan 2021 07:57:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvJzH-0003Sm-KT for bug-gnulib@gnu.org; Fri, 01 Jan 2021 07:56:59 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:35234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvJzF-0003h9-CO for bug-gnulib@gnu.org; Fri, 01 Jan 2021 07:56:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1609505814; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:From:Subject: Sender; bh=Pt9QGjQGWq3vM+Xf5iGZZIgbLy1DghaHVUu+mnOGOUY=; b=K2WY52HtJD4/g+K0gswcQ3AMTE50Fp87LTkfZBqAqV2VYebTmjXDGqlzHUN7dmTUZS YoGQjLoMAfEtbwa5tKrHg89JRHZ71nsmmolyKnBXr6d8NlVidkZVMN1EkMlkH8av0I00 stnDkW9SZideOUeM7EzRdvtuK/YQEW6lH6ERwIV9rx4JClZxf2qmD1wa3sECkGUb21dw WgMLRlJ76kdjkIw+wrAjyCssIsiuRytQft2sUm1A8RB3sNK+oLCrLPLf1CteAFety39P 95sCuTfI3t0TdafuHcDCg+m6jQeZ5HAK3F1twPRtxliV5WK4DPfbHzGzQtKn84/pyLE6 Hchg== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOH6f3z/s=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 47.10.7 DYNA|AUTH) with ESMTPSA id e012d5x01CusXPQ (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Fri, 1 Jan 2021 13:56:54 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org, Bernhard Voelker Subject: Re: test-getgroups.c:stringop-overflow warning on newer GCC Date: Fri, 01 Jan 2021 13:56:53 +0100 Message-ID: <2887419.1QkhuepXuh@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-197-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Received-SPF: none client-ip=81.169.146.220; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -54 X-Spam_score: -5.5 X-Spam_bar: ----- X-Spam_report: (-5.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.749, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Hi Berny, Bernhard Voelker wrote in : > Newer GCC complains about this test: >=20 > $ make test-getgroups.o V=3D1 > depbase=3D`echo test-getgroups.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\ > gcc -DHAVE_CONFIG_H -DEXEEXT=3D\"\" -I. -I.. -DIN_FINDUTILS_GNULIB_TES= TS=3D1 -I. -I. -I.. -I./.. -I../gl/lib -I./.. \ > /gl/lib -g -O2 -MT test-getgroups.o -MD -MP -MF $depbase.Tpo -c -o = test-getgroups.o test-getgroups.c &&\ > mv -f $depbase.Tpo $depbase.Po > In file included from test-getgroups.c:31: > test-getgroups.c: In function 'main': > test-getgroups.c:65:11: warning: argument 1 value -1 is negative [-Wstr= ingop-overflow=3D] > 65 | ASSERT (getgroups (-1, NULL) =3D=3D -1); > | ^~~~~~~~~~~~~~~~~~~~ I can't reproduce this with a testdir created through ./gnulib-tool --create-testdir --dir=3D... --single-configure getgroups and GCC 10.2.0, even with '-Wall' (whereas the GCC invocation that you show= does not invoke any warning options!): $ gcc -DHAVE_CONFIG_H -I. -I.. -DGNULIB_STRICT_CHECKING=3D1 -DIN_GNULIB_TE= STS=3D1 -I. -I. -I.. -I./.. -I../gllib -I./../gllib -g -O2 -c test-getgro= ups.c -Wall (no diagnostics) Also, it's strange that this warning reports to come from -Wstringop-overfl= ow =E2=80=94 whereas 'getgroups' is not a string operation. So, to me it looks like a bug in the particular GCC version that you are us= ing. Under regular circumstances, I would consider adding a #pragma GCC diagnost= ic, as you suggest, but not under these circumstances. Bruno