bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Ondrej Valousek <ondrej.valousek.xm@renesas.com>
Subject: Re: [PATCH] better explain functions [q]set-acl.c
Date: Wed, 11 Jan 2023 17:14:06 +0100	[thread overview]
Message-ID: <2801917.yFuDdFVEAc@nimes> (raw)
In-Reply-To: <20230109135430.1497446-1-ondrej.valousek.xm@renesas.com>

Ondrej Valousek wrote:
> +/* Set the access control lists of a file to match EXACTLY mode (this might

In function comments, by convention we refer to parameters by uppercasing their
name. So, this line should probably better read

   /* Set the access control lists of a file to match *exactly* MODE (this might

Bruno





  reply	other threads:[~2023-01-11 16:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 13:54 [PATCH] better explain functions [q]set-acl.c Ondrej Valousek
2023-01-11 16:14 ` Bruno Haible [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-16 13:29 Ondrej Valousek
2023-01-16 13:38 ` Bruno Haible
2023-01-16 13:42 Ondrej Valousek
2023-01-16 17:19 ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2801917.yFuDdFVEAc@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=ondrej.valousek.xm@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).