From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BB6B61F461 for ; Tue, 20 Aug 2019 16:42:12 +0000 (UTC) Received: from localhost ([::1]:39728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i07D1-0001LY-UQ for normalperson@yhbt.net; Tue, 20 Aug 2019 12:42:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47051) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i07Cy-0001LR-3f for bug-gnulib@gnu.org; Tue, 20 Aug 2019 12:42:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i07Cx-00052j-3c for bug-gnulib@gnu.org; Tue, 20 Aug 2019 12:42:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36598) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i07Cw-000527-RM for bug-gnulib@gnu.org; Tue, 20 Aug 2019 12:42:07 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 386A830917AC for ; Tue, 20 Aug 2019 16:42:06 +0000 (UTC) Received: from [10.3.116.234] (ovpn-116-234.phx2.redhat.com [10.3.116.234]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 02F2A10013A1 for ; Tue, 20 Aug 2019 16:42:05 +0000 (UTC) Subject: Re: [PATCH] accept4: Support SOCK_NONBLOCK, if defined To: bug-gnulib@gnu.org References: <20190820163727.5189-1-eblake@redhat.com> From: Eric Blake Openpgp: preference=signencrypt Autocrypt: addr=eblake@redhat.com; keydata= xsBNBEvHyWwBCACw7DwsQIh0kAbUXyqhfiKAKOTVu6OiMGffw2w90Ggrp4bdVKmCaEXlrVLU xphBM8mb+wsFkU+pq9YR621WXo9REYVIl0FxKeQo9dyQBZ/XvmUMka4NOmHtFg74nvkpJFCD TUNzmqfcjdKhfFV0d7P/ixKQeZr2WP1xMcjmAQY5YvQ2lUoHP43m8TtpB1LkjyYBCodd+LkV GmCx2Bop1LSblbvbrOm2bKpZdBPjncRNob73eTpIXEutvEaHH72LzpzksfcKM+M18cyRH+nP sAd98xIbVjm3Jm4k4d5oQyE2HwOur+trk2EcxTgdp17QapuWPwMfhaNq3runaX7x34zhABEB AAHNHkVyaWMgQmxha2UgPGVibGFrZUByZWRoYXQuY29tPsLAegQTAQgAJAIbAwULCQgHAwUV CgkICwUWAgMBAAIeAQIXgAUCS8fL9QIZAQAKCRCnoWtKJSdDahBHCACbl/5FGkUqJ89GAjeX RjpAeJtdKhujir0iS4CMSIng7fCiGZ0fNJCpL5RpViSo03Q7l37ss+No+dJI8KtAp6ID+PMz wTJe5Egtv/KGUKSDvOLYJ9WIIbftEObekP+GBpWP2+KbpADsc7EsNd70sYxExD3liwVJYqLc Rw7so1PEIFp+Ni9A1DrBR5NaJBnno2PHzHPTS9nmZVYm/4I32qkLXOcdX0XElO8VPDoVobG6 gELf4v/vIImdmxLh/w5WctUpBhWWIfQDvSOW2VZDOihm7pzhQodr3QP/GDLfpK6wI7exeu3P pfPtqwa06s1pae3ad13mZGzkBdNKs1HEm8x6zsBNBEvHyWwBCADGkMFzFjmmyqAEn5D+Mt4P zPdO8NatsDw8Qit3Rmzu+kUygxyYbz52ZO40WUu7EgQ5kDTOeRPnTOd7awWDQcl1gGBXgrkR pAlQ0l0ReO57Q0eglFydLMi5bkwYhfY+TwDPMh3aOP5qBXkm4qIYSsxb8A+i00P72AqFb9Q7 3weG/flxSPApLYQE5qWGSXjOkXJv42NGS6o6gd4RmD6Ap5e8ACo1lSMPfTpGzXlt4aRkBfvb NCfNsQikLZzFYDLbQgKBA33BDeV6vNJ9Cj0SgEGOkYyed4I6AbU0kIy1hHAm1r6+sAnEdIKj cHi3xWH/UPrZW5flM8Kqo14OTDkI9EtlABEBAAHCwF8EGAEIAAkFAkvHyWwCGwwACgkQp6Fr SiUnQ2q03wgAmRFGDeXzc58NX0NrDijUu0zx3Lns/qZ9VrkSWbNZBFjpWKaeL1fdVeE4TDGm I5mRRIsStjQzc2R9b+2VBUhlAqY1nAiBDv0Qnt+9cLiuEICeUwlyl42YdwpmY0ELcy5+u6wz mK/jxrYOpzXKDwLq5k4X+hmGuSNWWAN3gHiJqmJZPkhFPUIozZUCeEc76pS/IUN72NfprZmF Dp6/QDjDFtfS39bHSWXKVZUbqaMPqlj/z6Ugk027/3GUjHHr8WkeL1ezWepYDY7WSoXwfoAL 2UXYsMAr/uUncSKlfjvArhsej0S4zbqim2ZY6S8aRWw94J3bSvJR+Nwbs34GPTD4Pg== Organization: Red Hat, Inc. Message-ID: <279546c7-1881-6f2b-239d-657786947182@redhat.com> Date: Tue, 20 Aug 2019 11:42:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190820163727.5189-1-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p6rlVlb2yHsxnClYsMTgV3AYKmPNZcufj" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 20 Aug 2019 16:42:06 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --p6rlVlb2yHsxnClYsMTgV3AYKmPNZcufj Content-Type: multipart/mixed; boundary="MEpsmBHOPkUdcMOw5xqPNFXJa8RkrfGQZ"; protected-headers="v1" From: Eric Blake To: bug-gnulib@gnu.org Message-ID: <279546c7-1881-6f2b-239d-657786947182@redhat.com> Subject: Re: [PATCH] accept4: Support SOCK_NONBLOCK, if defined References: <20190820163727.5189-1-eblake@redhat.com> In-Reply-To: <20190820163727.5189-1-eblake@redhat.com> --MEpsmBHOPkUdcMOw5xqPNFXJa8RkrfGQZ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/20/19 11:37 AM, Eric Blake wrote: > Ideally, we would improve our replacement to define a > replacement SOCK_NONBLOCK on all platforms, and teach socket() to > honor it as well; but that's a bigger task. In the meantime, if the > platform already has SOCK_NONBLOCK, we should honor it when doing a > fallback. >=20 >=20 > +#if SOCK_CLOEXEC > + if (flags & SOCK_NONBLOCK) > + { > + int fcntl_flags; > + > + if ((fcntl_flags =3D fcntl (fd, F_GETFL, 0)) < 0 > + || fcntl (fd, F_SETFL, fcntl_flags | O_NONBLOCK) =3D=3D -1) Hmm, I guess it would be better to make the accept4 module depend on nonblocking, and call set_nonblocking() instead of open-coding the Unix-only solution (but this works for now as long as mingw lacks SOCK_NONBLOCK natively, and as long as we don't have declaring a replacement SOCK_NONBLOCK)... --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org --MEpsmBHOPkUdcMOw5xqPNFXJa8RkrfGQZ-- --p6rlVlb2yHsxnClYsMTgV3AYKmPNZcufj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAl1cIt0ACgkQp6FrSiUn Q2qEcAf/b5tALHVeRouWT8EuC2vNVSi5q7Nr1AFjIK4kpARdR8f9E4oMQh0KPQum sm2TdPgAtTBPqHPyaBhKeiahcinrLo1ECAN3CWnUARvnQy79OcvHgPaTDW5sR7CL doVYxp9tshzYZaGLtXdNwBKQMux2pvEo7uISvR9HhCmtpNNGJW89HRkhevK+SHSZ CFZODFPtIm1/Ol9T5I86LYxq9MDP8UCCOuu33Felz0Tmz8KT/wFaD+IchZVeh/Ux VFPw8p90lROFQg+2NnKSWFUNs2VkUwfH0G4cNPWWNFZXu2fiL3aN5JDS9GB6Y6AV f6EUOZUI68MqkXmdux+7eYPTSu0zCg== =85Td -----END PGP SIGNATURE----- --p6rlVlb2yHsxnClYsMTgV3AYKmPNZcufj--