From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-4.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 292AF1F698 for ; Wed, 28 Dec 2022 04:13:47 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=cs.ucla.edu header.i=@cs.ucla.edu header.a=rsa-sha256 header.s=78364E5A-2AF3-11ED-87FA-8298ECA2D365 header.b=dLiidMWo; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pANoo-0005gy-A1; Tue, 27 Dec 2022 23:13:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pANom-0005gn-Cx for bug-gnulib@gnu.org; Tue, 27 Dec 2022 23:13:28 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pANoj-0007PE-Mr for bug-gnulib@gnu.org; Tue, 27 Dec 2022 23:13:27 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B76FC16004F; Tue, 27 Dec 2022 20:13:22 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id P2vAdh68lfJ6; Tue, 27 Dec 2022 20:13:21 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 87EAD160048; Tue, 27 Dec 2022 20:13:21 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 87EAD160048 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1672200801; bh=l1U/pJUpd/1QLuuMtibBcDi6qHu9aok2tAot3Bk+VLk=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:From:To; b=dLiidMWo0YJAQtsIgBD9HEuJe7ZFl0uuSZQCdSkOiAbNyrY7s9LrUckNmTq+xZiJB ESM0kIUqxDTbxZena6qu+H2bX0leMFMO6KWoVzLOEKymZPIzrvBS2oBgQnRgSWFlsJ sELPuXBupB6fnVHoWVCRTvFlkeyFCr1py3eIhOIo= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SFXu_mSiaJlZ; Tue, 27 Dec 2022 20:13:21 -0800 (PST) Received: from [192.168.86.236] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5C3E8160043; Tue, 27 Dec 2022 20:13:21 -0800 (PST) Content-Type: multipart/mixed; boundary="------------qC0QnFKNFMTTKUZBBk6PZcBf" Message-ID: <271ee2f5-aaa6-97a3-b6fa-82a00a429d68@cs.ucla.edu> Date: Tue, 27 Dec 2022 20:13:21 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux Content-Language: en-US From: Paul Eggert To: Ondrej Valousek Cc: Gnulib bugs References: <20221202124018.1446189-1-ondrej.valousek.xm@renesas.com> <3414493.zog1K27m0d@nimes> <79add5ff-bb1d-0508-061f-1710797ff752@cs.ucla.edu> In-Reply-To: <79add5ff-bb1d-0508-061f-1710797ff752@cs.ucla.edu> Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-1.147, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org This is a multi-part message in MIME format. --------------qC0QnFKNFMTTKUZBBk6PZcBf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Some static checking helped find an off-by-one bug that I introduced to your Gnulib patch. The bug caused file_has_acl to sometimes incorrectly return -1 when given a nontrivial ACL in which a WHOLEN is a multiple of 4. Sorry about that. I installed the attached further patch to fix it. --------------qC0QnFKNFMTTKUZBBk6PZcBf Content-Type: text/x-patch; charset=UTF-8; name="0001-file-has-acl-fix-recently-introduced-NFSv4-bug.patch" Content-Disposition: attachment; filename*0="0001-file-has-acl-fix-recently-introduced-NFSv4-bug.patch" Content-Transfer-Encoding: base64 RnJvbSBkNjVlNWE4YmE3NzU5NWE1OThjOWRkYjhkZmEwOWM0YWVhNzMyNjU5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDI3IERlYyAyMDIyIDIwOjAwOjU4IC0wODAwClN1YmplY3Q6IFtQQVRD SF0gZmlsZS1oYXMtYWNsOiBmaXggcmVjZW50bHktaW50cm9kdWNlZCBORlN2NCBidWcKCiog bGliL2ZpbGUtaGFzLWFjbC5jIChhY2xfbmZzNF9ub250cml2aWFsKTogRml4IG9mZi1ieS1v bmUKZXJyb3Igd2hlbiByb3VuZGluZyBXSE9MRU4gdXAgdG8gbmV4dCBtdWx0aXBsZSBvZiA0 LgpQYWNpZnkgR0NDIDEyLjIuMSAtV2Nhc3QtYWxpZ24uCi0tLQogQ2hhbmdlTG9nICAgICAg ICAgIHwgNSArKysrKwogbGliL2ZpbGUtaGFzLWFjbC5jIHwgOSArKysrKy0tLS0KIDIgZmls ZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMTJjMTRhMmU3YS4uYmUwZmIyMjA3 OCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDEw IEBACiAyMDIyLTEyLTI3ICBQYXVsIEVnZ2VydCAgPGVnZ2VydEBjcy51Y2xhLmVkdT4KIAor CWZpbGUtaGFzLWFjbDogZml4IHJlY2VudGx5LWludHJvZHVjZWQgTkZTdjQgYnVnCisJKiBs aWIvZmlsZS1oYXMtYWNsLmMgKGFjbF9uZnM0X25vbnRyaXZpYWwpOiBGaXggb2ZmLWJ5LW9u ZQorCWVycm9yIHdoZW4gcm91bmRpbmcgV0hPTEVOIHVwIHRvIG5leHQgbXVsdGlwbGUgb2Yg NC4KKwlQYWNpZnkgR0NDIDEyLjIuMSAtV2Nhc3QtYWxpZ24uCisKIAlBZGQgLS1wdWxsLCAt LWdlbiBvcHRpb25zIHRvIGJ1aWxkLWF1eC9ib290c3RyYXAKIAlUaGlzIHN1cHBvcnRzIGEg c2luZ2xlIGJvb3RzdHJhcCBzY3JpcHQgd2l0aCAtLXB1bGwgYW5kIC0tZ2VuCiAJb3B0aW9u cywgYXMgYW4gYWx0ZXJuYXRpdmUgdG8gc2VwYXJhdGUgYXV0b2dlbi5zaCBhbmQgYXV0b3B1 bGwuc2gKZGlmZiAtLWdpdCBhL2xpYi9maWxlLWhhcy1hY2wuYyBiL2xpYi9maWxlLWhhcy1h Y2wuYwppbmRleCA2NzY1MjNiYTgyLi43ODc2ZWRjNGYwIDEwMDY0NAotLS0gYS9saWIvZmls ZS1oYXMtYWNsLmMKKysrIGIvbGliL2ZpbGUtaGFzLWFjbC5jCkBAIC04MSw5ICs4MSwxMCBA QCBhY2xfbmZzNF9ub250cml2aWFsICh1aW50MzJfdCAqeGF0dHIsIHNzaXplX3QgbmJ5dGVz KQogICAgICAgdWludDMyX3QgZmxhZyA9IG50b2hsICh4YXR0clsxXSk7CiAgICAgICB1aW50 MzJfdCB3aG9sZW4gPSBudG9obCAoeGF0dHJbM10pOwogICAgICAgeGF0dHIgKz0gNDsKLSAg ICAgIGludDY0X3Qgd2hvbGVuNCA9IHdob2xlbjsKLSAgICAgIHdob2xlbjQgPSAoKHdob2xl bjQgKyAoQllURVNfUEVSX05FVFdPUktfVUlOVCkpCi0gICAgICAgICAgICAgICAgICYgfiAo QllURVNfUEVSX05FVFdPUktfVUlOVCAtIDEpKTsKKyAgICAgIGludCB3aG93b3JkcyA9ICh3 aG9sZW4gLyBCWVRFU19QRVJfTkVUV09SS19VSU5UCisgICAgICAgICAgICAgICAgICAgICAg KyAod2hvbGVuICUgQllURVNfUEVSX05FVFdPUktfVUlOVCAhPSAwKSk7CisgICAgICBpbnQ2 NF90IHdob2xlbjQgPSB3aG93b3JkczsKKyAgICAgIHdob2xlbjQgKj0gQllURVNfUEVSX05F VFdPUktfVUlOVDsKIAogICAgICAgLyogVHJpdmlhbCBBQ0xzIGhhdmUgb25seSBBQ0U0X0FD Q0VTU19BTExPV0VEX0FDRV9UWVBFIG9yCiAgICAgICAgICBBQ0U0X0FDQ0VTU19ERU5JRURf QUNFX1RZUEUuICAqLwpAQCAtMTE1LDcgKzExNiw3IEBAIGFjbF9uZnM0X25vbnRyaXZpYWwg KHVpbnQzMl90ICp4YXR0ciwgc3NpemVfdCBuYnl0ZXMpCiAgICAgICAgIHJldHVybiAxOwog ICAgICAgYWNlX2ZvdW5kIHw9IGFjZV9mb3VuZF9iaXQ7CiAKLSAgICAgIHhhdHRyID0gKHVp bnQzMl90ICopICgoY2hhciAqKSB4YXR0ciArIHdob2xlbjQpOworICAgICAgeGF0dHIgKz0g d2hvd29yZHM7CiAgICAgfQogCiAgIHJldHVybiAwOwotLSAKMi4yNS4xCgo= --------------qC0QnFKNFMTTKUZBBk6PZcBf--