From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id DF1E71F5AE for ; Fri, 30 Apr 2021 23:14:25 +0000 (UTC) Received: from localhost ([::1]:35750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lccL2-00030l-J9 for normalperson@yhbt.net; Fri, 30 Apr 2021 19:14:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lccKy-00030d-Iw for bug-gnulib@gnu.org; Fri, 30 Apr 2021 19:14:20 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.21]:13458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lccKu-00010T-RF for bug-gnulib@gnu.org; Fri, 30 Apr 2021 19:14:20 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1619824454; cv=none; d=strato.com; s=strato-dkim-0002; b=aUlrj15D0VaOI+ay2sV5NPSoJShC/Pgra0eXI3EWeicWILtcXi4/t7BziNeOaBr3fU ihNsRXOxdRqY6WPntcuo/3VveqkXa2/AfqcANa6capGCeHIxFRt3w7c2K9GOezRIgVtI qIKygehBZvWLv2BVmnLR5BpXve9B7q7Idea0v6EoTpYwYx/HYDbNGgq88GydapyGCefe RImoyrEdCS2XRwbGroMhoiXQk+qq4dVXsT8csYqLEmyJqnblAe4cppJHDfiFHX1yQ/14 yjNtc7teBr1SOC6fJ9tHR0XVQdMk0BfR9JLBxBCHYzXWB7W0giEiReNmnpRLRqeDQ6Id 0tqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1619824454; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=OHBpVeOh9zyiVapKJZtOcTIPj3LTIoO18TTs2mYdQkA=; b=my0tFBpx2CMa2TRjQsDHKeS6hWlymcqH1s0vlZLOObeLHSId87cn+zIhPOMlbY8vxV bSY5iuSRaWWlUJgzw22r+ZKDiM0zXECNwDwso4LKV2xspUY4tgkweCpsxgPlbyPL/1H5 qJuQt1Q0Zki7APcX+afqn1NCpilHanluklLcs1jclM2lotphr0PbN//2FkW1k7cn8QYh R6ak/vta7ZvYf4qSRpeAEZhkhRNdOwL0n+fT8J8+Xv38NNbpERk+NzV5R5vrcoTF9uLK ufsVdoe0+VbT41Ek6lgZuzVDsW2fRy+ugbeazlG7x7w2Y2Uwshyh5jTPWE8SGxikkC0p lcHA== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1619824454; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=OHBpVeOh9zyiVapKJZtOcTIPj3LTIoO18TTs2mYdQkA=; b=k/p8BoVO0W3fRVFHZdkjIQ5piwAtSzBkDBYUBOsFumsyzsOx15ATibXY7VlqSvORxz MEJ0XEDN5Y6IDWuh3rgceqlQeHPrTH7LuRsKYgFCz9E0GEwWU3gR38ysBh+/rqykSm3/ MoItRFb4JCURaph1QpA1jskHNalCZ8BiOkNmSM2WfgoI56uHH16//ALG39ge4e3ZNK/I 7Ey+cSkcbR+rePm8yseiiZrIcjwtQCUKtf1YG0nt1gNXZhXfwk5KBS+rKIZ1S9QjvbNU oMbuYVXwEGyFzr6i8EIQc0hqqghBi4jYkdGdFbNMlwyIHMvZSLBW8Dk0fIezTa3WMr9v yoPA== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOHqf3z5NW" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 47.25.2 DYNA|AUTH) with ESMTPSA id 905ad3x3UNEDLPj (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sat, 1 May 2021 01:14:13 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: immutable: Fix crash when immmalloc() fails Date: Sat, 01 May 2021 01:14:13 +0200 Message-ID: <2703361.22hd3GMMjE@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-206-generic; KDE/5.18.0; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.21; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Compiling a testdir with CC="gcc -fanalyzer" produced this warning: ../../gllib/immutable.c:333:3: warning: use of NULL 'wp' where non-null expected [CWE-476] [-Wanalyzer-null-argument] 2021-04-30 Bruno Haible immutable: Fix crash when immmalloc() fails. Found by GCC 11 '-fanalyzer'. * lib/immutable.c (immstrdup): Don't crash when immmalloc() fails. diff --git a/lib/immutable.c b/lib/immutable.c index 35f7397..e4f3825 100644 --- a/lib/immutable.c +++ b/lib/immutable.c @@ -330,6 +330,8 @@ immstrdup (const char *string) { size_t size = strlen (string) + 1; void *wp = immmalloc (size); + if (wp == NULL) + return NULL; memcpy (wp, string, size); return (const char *) immfreeze (wp); }