bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: "Brian C. Lane" <bcl@redhat.com>
Subject: Re: update-copyright is broken
Date: Tue, 16 Jul 2019 10:03:10 +0200	[thread overview]
Message-ID: <2702799.gSeAclHnIc@omega> (raw)
In-Reply-To: <20190715235026.GD3791@lister.brianlane.com>

Hi,

Brian C. Lane wrote:
> I think it was the change in commit a05d5d121b10f24 where it moved and
> changed the exec code at line 1.
> 
> In parted with the latest gnulib I am getting these errors with 'make
> update-copyright'
> 
>   GEN      update-copyright
> Use of uninitialized value $_ in pattern match (m//) at ./build-aux/update-copyright line 167.
> Use of uninitialized value $_ in pattern match (m//) at ./build-aux/update-copyright line 173.
> Use of uninitialized value $ARGV in concatenation (.) or string at ./build-aux/update-copyright line 285.
> : warning: copyright statement not found
> 
> If I edit the new exec line to use the old one, but with -wSx, it works fine:
> 
> eval '(exit $?0)' && eval 'exec perl -wSx -0777 -pi "$0" ${1+"$@"}'
>   & eval 'exec perl -wSx -0777 -pi "$0" $argv:q'
>       if 0;

Thanks for the report. Indeed, a bad regression. Fixed as follows:


2019-07-16  Bruno Haible  <bruno@clisp.org>

	update-copyright: Make it work again (regression from 2019-06-15).
	Reported by Brian C. Lane <bcl@redhat.com>.
	* build-aux/update-copyright: Add back the -0777, -p, -i options.

diff --git a/build-aux/update-copyright b/build-aux/update-copyright
index 4a9ea7c..b3f6b29 100755
--- a/build-aux/update-copyright
+++ b/build-aux/update-copyright
@@ -134,7 +134,7 @@
 # the script through the perl program found in $PATH.  The '-x' option
 # is essential as well; without it, perl would re-execute the script
 # through /bin/sh.  When executed by  perl, the next two lines are a no-op.
-eval 'exec perl -wSx "$0" "$@"'
+eval 'exec perl -wSx -0777 -pi "$0" "$@"'
      if 0;
 
 my $VERSION = '2018-03-07.03:47'; # UTC



  reply	other threads:[~2019-07-16  8:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 23:50 update-copyright is broken Brian C. Lane
2019-07-16  8:03 ` Bruno Haible [this message]
2019-07-17  6:44   ` Bernhard Voelker
2019-07-19 23:22     ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2702799.gSeAclHnIc@omega \
    --to=bruno@clisp.org \
    --cc=bcl@redhat.com \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).