bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: ptrdiff_t overflow checks for malloc-posix etc.
Date: Sun, 18 Apr 2021 14:13:22 +0200	[thread overview]
Message-ID: <2529001.6S2N5fhDcN@omega> (raw)
In-Reply-To: <64417dd6-7edb-2045-d827-2dd24b151205@cs.ucla.edu>

Hi Paul,

> * m4/realloc.m4 (_AC_FUNC_REALLOC_IF):
> Don’t start with a newline.

This is not very robust. We usually don't care about newlines or useless
indentation in the generated configure.ac any more. Therefore future
edits may reintroduce a newline here. It would be more robust to change

  test $REPLACE_REALLOC = 1 || _AC_FUNC_REALLOC_IF([], [REPLACE_REALLOC=1])

to

  if test $REPLACE_REALLOC = 0; then
    _AC_FUNC_REALLOC_IF([], [REPLACE_REALLOC=1])
  fi

Bruno



  parent reply	other threads:[~2021-04-18 12:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18  2:02 ptrdiff_t overflow checks for malloc-posix etc Paul Eggert
2021-04-18 11:59 ` Bruno Haible
2021-04-18 12:11 ` Bruno Haible
2021-04-18 20:24   ` Paul Eggert
2021-04-18 20:32     ` Bruno Haible
2021-04-18 12:13 ` Bruno Haible
2021-04-18 19:47   ` Paul Eggert
2021-04-18 20:23     ` Bruno Haible
2021-04-18 22:33       ` Paul Eggert
2021-04-19  0:04         ` Bruno Haible
2021-04-19  4:20           ` Paul Eggert
2021-04-18 12:13 ` Bruno Haible [this message]
2021-04-18 18:37   ` Paul Eggert
2021-05-09 20:19     ` Bruno Haible
2021-05-09 23:00       ` Bruno Haible
2021-05-10  8:45         ` Paul Eggert
2021-05-09 16:46 ` Bruno Haible

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2529001.6S2N5fhDcN@omega \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).