bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Pavel Raiskup <praiskup@redhat.com>
To: Bruno Haible <bruno@clisp.org>
Cc: bug-gnulib@gnu.org
Subject: Re: gnulib-tool: Improve handling of multiple --local-dir options
Date: Wed, 20 Feb 2019 08:03:16 +0100	[thread overview]
Message-ID: <2518009.NOBulbDumm@raiskup> (raw)
In-Reply-To: <2931584.EFCJPvSFVq@omega>

On Tuesday, February 19, 2019 7:18:57 PM CET Bruno Haible wrote:
> Hi Pavel,
> 
> > > makes the IFS handling a bit more robust.
> 
> What I meant is that
> 
>    save_IFS="$IFS"
>    for fpf_dir in $fpf_dirs
>    do
>      IFS="$save_IFS"
>      [Some more code]
>    done
>    IFS="$save_IFS"
> 
> is more robust than
> 
>    save_IFS="$IFS"
>    for fpf_dir in $fpf_dirs
>    do
>      [Some more code]
>    done
>    IFS="$save_IFS"
> 
> because the [Some more code] may invoke word splitting, and as a programmer
> I would expect this word splitting to be performed against the default IFS.

Makes sense, thanks.  I was only confused by the var="$quoted_var" style,
which I was before discouraged from.

Pavel





      reply	other threads:[~2019-02-20  7:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14 19:53 gnulib-tool: Improve handling of multiple --local-dir options Bruno Haible
2019-02-19 15:39 ` Pavel Raiskup
2019-02-19 18:02   ` shell variable references - coding style Bruno Haible
2019-02-19 19:41     ` Jim Meyering
2019-03-13 12:46     ` Pavel Raiskup
2019-03-13 17:15       ` Paul Eggert
2019-03-13 19:04       ` Bruno Haible
2019-02-19 18:18   ` gnulib-tool: Improve handling of multiple --local-dir options Bruno Haible
2019-02-20  7:03     ` Pavel Raiskup [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2518009.NOBulbDumm@raiskup \
    --to=praiskup@redhat.com \
    --cc=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).