From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 329B91F8C6 for ; Sat, 7 Aug 2021 13:39:12 +0000 (UTC) Received: from localhost ([::1]:41320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCMXe-0002r6-PK for normalperson@yhbt.net; Sat, 07 Aug 2021 09:39:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCMKZ-0004pM-9V for bug-gnulib@gnu.org; Sat, 07 Aug 2021 09:25:39 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.165]:13894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCMKX-0003uT-Ic for bug-gnulib@gnu.org; Sat, 07 Aug 2021 09:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1628342727; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=3D0SsglsK/dqD0FuOyFH8J8Fz3WMj1vUsoIEw/83GXw=; b=qctihjKshXagJCrZVEdbIBP/ef3JkQvYVWV2ekl8nbgFYwFevAold/lRB8Z9snnRF4 VoMhJQuXhSokWuNFYyfuvVwaaB4dZ2G/U1hxdEszDZyUZR4eAIULpkUquHqIdBpHc8dx 9N5QPVup0T4JF9rjU46PkfzLYYKLUBNUcWAgv6rnqcgS1bZDD9cOuCd55KIwmPN7FhmA Q1hG0gDY15MfcV6nrjxPcK8mcpjZUO68qlYj1xUUcU1JvxHfYfWIOjjjBdG427aukno6 SCAYdSR0OPVDukEC4/90U6F9CRIj7lljajM7hCwW/pZO6IfGf2Ru1kUneQOSuqNoA3a8 /UDQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH/DXj0JGsbh0vbrMZq" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 47.31.0 DYNA|AUTH) with ESMTPSA id I0a189x77DPRFNW (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Sat, 7 Aug 2021 15:25:27 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: [PATCH 11/27] quotearg: improve -fanalyzer malloc checking Date: Sat, 07 Aug 2021 15:25:26 +0200 Message-ID: <2503132.QJkmmk4NOB@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-210-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20210802011821.1057057-11-eggert@cs.ucla.edu> References: <20210802011821.1057057-1-eggert@cs.ucla.edu> <20210802011821.1057057-11-eggert@cs.ucla.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.165; envelope-from=bruno@clisp.org; helo=mo4-p01-ob.smtp.rzone.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Eggert Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Paul Eggert wrote: > @@ -342,7 +344,10 @@ char *quotearg_alloc (char const *arg, size_t argsize, > backslash escapes, and the flags of O do not request elision of > null bytes.*/ > char *quotearg_alloc_mem (char const *arg, size_t argsize, > - size_t *size, struct quoting_options const *o); > + size_t *size, struct quoting_options const *o) > + _GL_ATTRIBUTE_MALLOC _GL_ATTRIBUTE_DEALLOC_FREE > + _GL_ATTRIBUTE_RETURNS_NONNULL; > +; > > /* Use storage slot N to return a quoted version of the string ARG. > Use the default quoting options. > This patch introduced a stray semicolon. 2021-08-07 Bruno Haible quotearg: Tweak last commit. * lib/quotearg.h: Don't include . Remove stray semicolon. diff --git a/lib/quotearg.h b/lib/quotearg.h index 22c09bc..f5644b8 100644 --- a/lib/quotearg.h +++ b/lib/quotearg.h @@ -21,7 +21,6 @@ #ifndef QUOTEARG_H_ # define QUOTEARG_H_ 1 -# include # include /* Basic quoting styles. For each style, an example is given on the @@ -279,6 +278,7 @@ struct quoting_options; struct quoting_options *clone_quoting_options (struct quoting_options *o) _GL_ATTRIBUTE_MALLOC _GL_ATTRIBUTE_DEALLOC_FREE _GL_ATTRIBUTE_RETURNS_NONNULL; + /* Get the value of O's quoting style. If O is null, use the default. */ enum quoting_style get_quoting_style (struct quoting_options const *o); @@ -347,7 +347,6 @@ char *quotearg_alloc_mem (char const *arg, size_t argsize, size_t *size, struct quoting_options const *o) _GL_ATTRIBUTE_MALLOC _GL_ATTRIBUTE_DEALLOC_FREE _GL_ATTRIBUTE_RETURNS_NONNULL; -; /* Use storage slot N to return a quoted version of the string ARG. Use the default quoting options.