From: Bruno Haible <bruno@clisp.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: "Tim Rühsen" <tim.ruehsen@gmx.de>, bug-gnulib@gnu.org
Subject: Re: gl_{,SN}PRINTF_DIRECTIVE_N wrongly fail on Ubuntu 18.04
Date: Mon, 16 Mar 2020 14:17:44 +0100 [thread overview]
Message-ID: <2502652.DdJKY97KcL@omega> (raw)
In-Reply-To: <11822349.64vXvSZc8K@omega>
I wrote:
> 2020-03-08 Bruno Haible <bruno@clisp.org>
>
> *printf-posix: Document why it's overridden on some glibc systems.
> Reported by Adrian Bunk <bunk@stusta.de> in
> <https://lists.gnu.org/archive/html/bug-gnulib/2020-03/msg00011.html>.
> * doc/posix-functions/*printf.texi: Document the problem with the %n
> directive on some glibc systems.
> * m4/printf.m4 (gl_PRINTF_DIRECTIVE_N, gl_SNPRINTF_DIRECTIVE_N): Adjust
> the cross-compilation guesses accordingly.
Oops, this patch had a mistake: It produced an error
executing aclocal -I glm4
/usr/bin/m4:configure.ac:4472: recursion limit of 1024 exceeded, use -L<N> to change it
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: echo failed with exit status: 1
Caught by the continuous integration - thanks Tim for setting it up!
2020-03-16 Bruno Haible <bruno@clisp.org>
*printf-posix: Fix m4 error (regression from 2020-03-08).
* m4/printf.m4 (gl_SNPRINTF_DIRECTIVE_N): Enable interpretation of
brackets in AC_COMPILE_IFELSE invocation.
diff --git a/m4/printf.m4 b/m4/printf.m4
index 54a2d71..df473d8 100644
--- a/m4/printf.m4
+++ b/m4/printf.m4
@@ -1,4 +1,4 @@
-# printf.m4 serial 63
+# printf.m4 serial 64
dnl Copyright (C) 2003, 2007-2020 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
@@ -1422,7 +1422,6 @@ int main ()
[gl_cv_func_snprintf_directive_n=yes],
[gl_cv_func_snprintf_directive_n=no],
[
-changequote(,)dnl
case "$host_os" in
# Guess no on glibc when _FORTIFY_SOURCE >= 2.
*-gnu* | gnu*) AC_COMPILE_IFELSE(
@@ -1434,6 +1433,7 @@ changequote(,)dnl
[gl_cv_func_snprintf_directive_n="guessing yes"],
[gl_cv_func_snprintf_directive_n="guessing no"])
;;
+changequote(,)dnl
# Guess yes on musl systems.
*-musl*) gl_cv_func_snprintf_directive_n="guessing yes";;
# Guess yes on FreeBSD >= 5.
@@ -1466,8 +1466,8 @@ changequote(,)dnl
mingw*) gl_cv_func_snprintf_directive_n="guessing no";;
# If we don't know, obey --enable-cross-guesses.
*) gl_cv_func_snprintf_directive_n="$gl_cross_guess_normal";;
- esac
changequote([,])dnl
+ esac
])
])
])
prev parent reply other threads:[~2020-03-16 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 11:19 gl_{,SN}PRINTF_DIRECTIVE_N wrongly fail on Ubuntu 18.04 Adrian Bunk
2020-03-08 17:59 ` Bruno Haible
2020-03-08 18:46 ` Adrian Bunk
2020-03-08 22:04 ` Bruno Haible
2020-03-08 23:38 ` Adrian Bunk
2020-03-09 0:11 ` Bruno Haible
2020-03-09 3:36 ` Paul Eggert
2020-03-16 13:17 ` Bruno Haible [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2502652.DdJKY97KcL@omega \
--to=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=bunk@stusta.de \
--cc=tim.ruehsen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).