From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6992D1F4B4 for ; Tue, 19 Jan 2021 18:53:10 +0000 (UTC) Received: from localhost ([::1]:56112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1w7o-0005AR-Sb for normalperson@yhbt.net; Tue, 19 Jan 2021 13:53:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1vT6-0006At-Jo for bug-gnulib@gnu.org; Tue, 19 Jan 2021 13:11:04 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.24]:23394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1vT2-0006Te-Lt for bug-gnulib@gnu.org; Tue, 19 Jan 2021 13:11:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1611079855; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:From: Subject:Sender; bh=yKMxs2Ua4kZopBK6HLtHXASkxH5TyvSnGuvrHsxQZ/k=; b=qr6hlapkiQxP6pc0u9gkhuZgwAmq3M2/Yp4ADLWCd6Rq709R7skDf3V/wT/9IlxKm8 Zs0VlVtxkqzHVe1cUnRw9DA0BWp509gofNfPZIenuhL0Pj/4XtoMs7j63cpoYKdY3/fs up77CYuqBUgh0BKo7q8VkD/4qjAkFaTWAxQLBrTAHxmk2UieQRFybQkI07qt+rUNxXh6 vUSYV6f+OrLol02hkzXM1mO4nFxrgJlA7UMqK8hTWCAbARQyGXNASEkuDUPOq2YtsZcr 27NrGc0+lRcBAUtN337ZuouvCI4Y3RRAGbzDFKBxvoiM7YFSiHzjzp/99QxMJ089nrQo iidg== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOHqfyyvs=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 47.12.1 DYNA|AUTH) with ESMTPSA id u0aa20x0JIAs48L (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Tue, 19 Jan 2021 19:10:54 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Subject: Re: [PATCH 5/7] zerosize-ptr: Fix compilation on OS/2 kLIBC Date: Tue, 19 Jan 2021 19:10:53 +0100 Message-ID: <2470197.9hkJXdE0Ak@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-197-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20210118164013.42063-5-komh@chollian.net> References: <20210118164013.42063-1-komh@chollian.net> <20210118164013.42063-5-komh@chollian.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.24; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: KO Myung-Hun Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Applied with modifications: > -#if HAVE_SYS_MMAN_H && HAVE_MPROTECT > +#if HAVE_SYS_MMAN_H && HAVE_MPROTECT && (!defined __KLIBC__ || HAVE_MMAP) There's a comment two lines above, that explains why HAVE_MMAP is not the right test here. And since you write "OS/2 kLIBC has and mprotect() but not mmap()", defined __KLIBC__ implies !HAVE_MMAP. Bruno