From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 146AD1F5AE for ; Thu, 10 Jun 2021 15:41:22 +0000 (UTC) Received: from localhost ([::1]:40804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrMo4-0005iD-SU for normalperson@yhbt.net; Thu, 10 Jun 2021 11:41:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrMo0-0005gW-O8 for bug-gnulib@gnu.org; Thu, 10 Jun 2021 11:41:16 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.21]:18781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrMny-0002Tl-5k for bug-gnulib@gnu.org; Thu, 10 Jun 2021 11:41:16 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1623339670; cv=none; d=strato.com; s=strato-dkim-0002; b=GvOxV3DS8MuX+1SgUmbxFyVtI2zxx1mCytGXo67nJmujXqR3mM0kLHHrdWFF3JPLb+ wOc3oddOACv8m6rDFKe3Z9dapPMjOqWRq+CHPHX4nANfCRIzBQYizfNip+9e4HGsuHIP exxeZHBIBnoh0FazC8H13A89aMOjFxp+MJwSrjGphb9BfVT0KO78fINZje+7ZDqoIzQ6 ZXb5XVuvIRAGICRRpn/jQ8bQO91bgM/9MXMB1mbrOna9B9zXzkbp0hPxwaLXlPbVrdsn XicYpGNnanhAZFjbBno0mDY/u4277cc8YOctCizGcWVoJXNe+QMvK5nh47V91Jr9jOh4 NjyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1623339670; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=puqIGuakTBQjciIa8RbkolUbJSFRXiRCiQsppyCftf4=; b=YSVPOHub/at3mO1cyXwIumkwuITx4R92ktwlZEGQkaGf0lHyjuYDaLx5bvXq0Z1zyf fAXnA7Aemp1HCCTSKSFvZc+TDU7NVuMGeBhmYK2GYq7ljb5abxdK/4hfS9OzXcgiJe8f lHq2XvecgM7oYfuR9ZL4FP8S+V2RjbcvNrmCW7ue41baxO0zazvDcsmfDIPf6vugkTbs vXtCOdcZwl1zjhGuqQxAjYcKiT0kdySQh+M80hcVnbpiGPI9t30NlCA33pC4jOcEmVf5 MkNMcMm/Vt/lL+0UUIYAUdKEBc4OO6Vq5Feq4CtfCLfL6vffxKbnI00qIUtAnTNxwdFi Kn/w== ARC-Authentication-Results: i=1; strato.com; dkim=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1623339670; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=puqIGuakTBQjciIa8RbkolUbJSFRXiRCiQsppyCftf4=; b=AMXyxbKt8jOhsd5pYELjzZ+xQxGgbE9e/c8GC0KqQrn8fQKkncCurnp+TqkTs+c8vk JGQwOrfq0nAPJ/Z4tvl59MjHnDZVrFaXZZO7cDJMkoR6z+ZK0oVFX4F3ZOhK1n4nuWda nn6Au207IFaTjCrlG8aLifFninVkV1XoUCd48sZNiTHcALGaQb4gKtFod+6WjYUNLWzL wTqhmwG9VUEpV9NgfgOWbSuy0uofE7sqsezts1t3Kgi0IVRiijj/CfbrFlZd/NsQJr7L tKWzCIIgNU3PN/K7YLKa1CrQZeHCT1eQ7W+XApwAjOq2nfktqLmKK6JXUVY2PRSnZurz M92w== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOHqf3z5NW" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 47.27.2 DYNA|AUTH) with ESMTPSA id q0869dx5AFf9iE9 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 10 Jun 2021 17:41:09 +0200 (CEST) From: Bruno Haible To: bug-gnulib@gnu.org Subject: two ill effects of maint.mk Date: Thu, 10 Jun 2021 17:41:08 +0200 Message-ID: <2220832.NeGGHjDtpa@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-210-generic; KDE/5.18.0; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.21; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" The Gnulib module 'maintainer-makefile' has two bad effects on the packages that import it. When GNU make is used (i.e. practically all GNU systems): 1) It executes the compilation of files (in lib/, src/, etc.) in the C locale. Thus, even if the user who builds the program has a preferred language (other than English) and GCC is built with enabled NLS, the 'maintainer-makefile' module forces English diagnostics onto the user. 2) It executes the unit tests ("make check-recursive", invoked by "make check") in the C locale. Thus, although most users nowadays execute programs in an UTF-8 locale (namely, the one set by their distro or desktop environment), the test suite only ever gets run in the C locale. This significantly reduces the value of the test suite. For example, GNU m4 has a unit test for every built-in function, and m4 1.4.19 introduced a regression in all locales which use a comma as decimal separator (this includes French and German locales). THE TEST SUITE did not catch it when run by the maintainer. It's only by building the package on DragonFly BSD that I noticed the regression (more than a week after the release, since obviously few GNU contributors use a non-GNU make). The bad effects affect * the developers who work from a git checkout + all users of the tarball for packages that include GNUmakefile and maint.mk in their tarballs, e.g. GNU findutils, GNU guile, GNU gzip, GNU libidn, GNU m4, GNU patch, GNU poke. * the developers who work from a git checkout only, for the other packages that use this module, e.g. GNU emacs, GNU gettext. In the second case, the testers of a pretest tarballs have a chance to discover the test failures that were hidden from the maintainers. In the first case, it's even worse, as only the use of non-GNU make can uncover the bugs. The line that causes these bad effects is in maint.mk: export LC_ALL = C Probably this line made sense when maint.mk was still called Makefile.maint and was independent. But since 2006 (or earlier) it is being included via GNUmakefile. Bruno