bug-gnulib@gnu.org mirror (unofficial)
 help / color / mirror / Atom feed
From: Bruno Haible <bruno@clisp.org>
To: bug-gnulib@gnu.org
Subject: libc-config: Apply lesson learned on 2023-01-13
Date: Mon, 29 Jan 2024 18:19:41 +0100	[thread overview]
Message-ID: <2173541.xEiunlC7Kx@nimes> (raw)

On 2023-01-13, Paul Eggert committed:

	* m4/gnulib-common.m4 (_GL_HAS_ATTRIBUTE): Require Clang 5 instead
	of 3.5 for this, to pacify xlclang 16.1.0 on AIX 7.2, which
	advertises itself as clang 4.0.1

The other use of __has_attribute, in lib/cdefs.h, should better be kept
consistent with this.


2024-01-29  Bruno Haible  <bruno@clisp.org>

	libc-config: Apply lesson learned on 2023-01-13.
	* lib/cdefs.h (__glibc_has_attribute): On non-Apple platforms, don't
	use __has_attribute for clang versions < 5.0.

diff --git a/lib/cdefs.h b/lib/cdefs.h
index 87ddce319d..1bb3c8f635 100644
--- a/lib/cdefs.h
+++ b/lib/cdefs.h
@@ -43,7 +43,7 @@
      && (!defined __clang_minor__ \
          || (defined __apple_build_version__ \
              ? 6000000 <= __apple_build_version__ \
-             : 3 < __clang_major__ + (5 <= __clang_minor__))))
+             : 5 <= __clang_major__)))
 # define __glibc_has_attribute(attr) __has_attribute (attr)
 #else
 # define __glibc_has_attribute(attr) 0





                 reply	other threads:[~2024-01-29 17:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2173541.xEiunlC7Kx@nimes \
    --to=bruno@clisp.org \
    --cc=bug-gnulib@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).