From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6950E1F61A for ; Sun, 11 Dec 2022 14:22:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.b="jKzf/0Sy"; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4NDu-0000w0-HJ; Sun, 11 Dec 2022 09:22:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4NDs-0000vc-6P for bug-gnulib@gnu.org; Sun, 11 Dec 2022 09:22:32 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4NDp-00055l-PU; Sun, 11 Dec 2022 09:22:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1670768544; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date: From:Subject:Sender; bh=k40uqhCIVlxZs5RN695PIN5i/pyEk2sevIjkaxorTVY=; b=jKzf/0Syh+ae3ZIiWNLttnHaZrfL4S2ELhkPoO5hNMY/Bqte3QW7q9fXIGleDkHEgo 5/ZWFDUgWE7ZXNt1SxswNZZK5Q83E5vzXshsSyNXU0buuKWudg3YnYyEV5yXNxSfDwLG kAFArlAZp02hy6L73bx/LaYi8u6sj9Yqwdn78NmipzgrWPRnKx4Vo4hJpJA5YyA4Dohg m0SRihtQx+kCeznoKafgyLhSqMAkzLFmqH+oiyZGDKUeMJuhaNcM0IbArY3dQCoIBKj9 K6LAFU3pvSc5KRBDCg4ttGfASBUkLy8hsWcvoEF/4Ks4ZGew9TVtWqHnOvpusFf0MC3U clcw== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOf2/0/UADLMLo9LPUP5As95K2DdA==" X-RZG-CLASS-ID: mo00 Received: from nimes.localnet by smtp.strato.de (RZmta 48.2.1 AUTH) with ESMTPSA id v9c7e6yBBEMOKU9 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Sun, 11 Dec 2022 15:22:24 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Cc: Roger Pack , Eli Zaretskii Subject: Re: gettimeofday.c windows version? Date: Sun, 11 Dec 2022 15:22:23 +0100 Message-ID: <2153083.vXnMlVU4IS@nimes> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.20; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Roger Pack wrote: > I received some complaints saying in mingw it was"requiring windows 8" for > a certain library. > > "Entry point not found, GetSystemTimePreciseAsFileTime could not be located > in the dynamic link library KERNEL32.dll". Indeed, according to the function GetSystemTimePreciseAsFileTime is not present in Windows 7 and older. Looking at the table at I see that Windows 7 is out of "extended support" already for more than 2 years. That means, users with such machines (connected to the internet) live very dangerously. Eli: What are the current support statements of Emacs regarding Windows XP/Vista/7 ? And should Gnulib declare that the minimum supported version of Windows is Windows 8? > Perhaps the following patch? Thanks! :) > > diff --git a/lib/gettimeofday.c b/lib/gettimeofday.c > index 36c7920af..428cc4f30 100644 > --- a/lib/gettimeofday.c > +++ b/lib/gettimeofday.c > @@ -35,7 +35,7 @@ > # undef LoadLibrary > # define LoadLibrary LoadLibraryA > > -# if !(_WIN32_WINNT >= _WIN32_WINNT_WIN8) > +# if (_WIN32_WINNT >= _WIN32_WINNT_WIN8) > > /* Avoid warnings from gcc -Wcast-function-type. */ > # define GetProcAddress \ > Nope, this patch is not right. > "Entry point not found, GetSystemTimePreciseAsFileTime could not be located > in the dynamic link library KERNEL32.dll". It looks like some code links directly to GetSystemTimePreciseAsFileTime, and your user is running it under Windows 7 or older. Which object file is it that links to GetSystemTimePreciseAsFileTime? - If it's not gettimeofday.c, it's not in Gnulib's responsibility. - If it is gettimeofday.c, this file must have been compiled with a _WIN32_WINNT value >= _WIN32_WINNT_WIN8. You need to look in your build files where this value come from. Maybe it is even the default with your compiler version; if that version is new enough, that would make sense. Bruno