From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7C5401F47C for ; Fri, 13 Jan 2023 07:52:08 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=gTEmB0wr; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGEqu-0008Ow-NM; Fri, 13 Jan 2023 02:51:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGEqs-0008On-Ld for bug-gnulib@gnu.org; Fri, 13 Jan 2023 02:51:50 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGEqq-0002U7-Ly for bug-gnulib@gnu.org; Fri, 13 Jan 2023 02:51:50 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1673596300; cv=none; d=strato.com; s=strato-dkim-0002; b=qlJiJMlOifplQ6Yo8ELw2m2h2bSUDhKwXCZVCgaQqfQ0wGcPgUUh2/TqqKQJdFMvWz NJ1QDGQZpJpYcKUdzfMh3Vw9YarrQ9eRBTKpJoa1CfsXQWOZ+Kykz3yaze2TjspBLzgb mAFqagWZoTlo9AN6h+om9mkL33iDn6IjyGKxS2/ULFw4+YlUQw8xYc1XiQwWgLIap/e2 ecXZFnSJlh8twWIWdtwBE4iVSuXFESV3WBab708fF8F/z16aehvJY9X6sEVc9IJep2FX iYPSQpmtFdj7O0wiLXq67tLcXFyI5PYtt6OS5mPQRBlLzvgvSg8Y9wIlYWcKmFZF/mtG /ENw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1673596300; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=qEpGUP9xd4sGqBqmIvrtgP3gQRGvnZPn0BytE8ocJck=; b=QcQFqa1y76WAKr8vnqR1D/Zgg1tlnIBIoEU80d3UARf3FM5a1hlX5Lq4pmwnW74qj5 /dK/orsDMPexxOBPzY+v6wiB7kKTvGExcXGKu6udOJEUgdpitzTP+U0wQkEExviWYIgG WkqraLtMINZ/Wjd8CDFGwyFRRnnbhvmzxUpH0uNSDUZk6m0zGNviD3F3R8qXlrB6mMzD U804hFrplaa4QS0b29sCj8TbZ4KXWhUmJBo8BF0Gk17g9PHiCAzos2s4JHSkVkxaw5Zt ZpOFNhj8ayb55rFtaZ4IDgM4L6CVTTPGzfEk6P4avpVK/Ps0IN5NBGJslzzFe4sz6ujA LD6Q== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1673596300; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=qEpGUP9xd4sGqBqmIvrtgP3gQRGvnZPn0BytE8ocJck=; b=gTEmB0wrYHucrGzauX97rVaiA3pJ535P5J4JFJhQsTVUI3sh0JtGDuzg0ll8sxvi/e pm2DOsxEgefpAf+WPSxGnxGfToMu6rodnV6cYEd8rIQKfrUeDLgVgw0rgStkNdbcZgZ7 9w+Chaf8eq9iC4pNBhp/xqWV8jSGp+KLj/W9QmDN8U8nhZUYWVeevDXuPp392216BIlT EinhGd1WHGAeoH8WnXZmf6s2hBhxbLfwlFcJW4i3m/uTS/W9sSL0tJsFI0QLttLpnF1U XieHO7anBCbwCejameY/HVXok5DVgTEE3wM1EcCWyIe0JVMwFd7VcWC45fl69PqhJ83Z puKA== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOXjv2XTu3l95++Pe54Opj0GYzUnQ==" Received: from nimes.localnet by smtp.strato.de (RZmta 48.6.2 AUTH) with ESMTPSA id I8f358z0D7pe9jH (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 13 Jan 2023 08:51:40 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org, Ondrej Valousek Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c Date: Fri, 13 Jan 2023 08:51:40 +0100 Message-ID: <2140227.aZlQVXGZEW@nimes> In-Reply-To: <3701455.LLGZZu3JSb@nimes> References: <20230104143425.1235741-1-ondrej.valousek.xm@renesas.com> <3701455.LLGZZu3JSb@nimes> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=85.215.255.20; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Hi Ondrej, How did you test your patch? When I run $ ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure \ acl-permissions copy-file qcopy-acl qset-acl supersede acl (with autoconf 2.71), I get two warnings: autoheader: warning: missing template: USE_XATTR autoheader: warning: Use AC_DEFINE([USE_XATTR], [], [Description]) This patch fixes them. But I would have expected that you fix it before you submit the patch. 2023-01-13 Bruno Haible qcopy-acl: Avoid autoconf warning. * m4/xattr.m4 (gl_FUNC_XATTR): Provide a description in AC_DEFINE. Also, protect against unsafe use of a configure option value. diff --git a/m4/xattr.m4 b/m4/xattr.m4 index 6efdfa475a..5cbfc86002 100644 --- a/m4/xattr.m4 +++ b/m4/xattr.m4 @@ -1,5 +1,5 @@ # xattr.m4 - check for Extended Attributes (Linux) -# serial 4 +# serial 5 # Copyright (C) 2003-2021 Free Software Foundation, Inc. # This file is free software; the Free Software Foundation @@ -16,7 +16,7 @@ AC_DEFUN([gl_FUNC_XATTR], LIB_XATTR= AC_SUBST([LIB_XATTR]) - if test "$use_xattr" = "yes"; then + if test "$use_xattr" = yes; then AC_CHECK_HEADERS([attr/error_context.h attr/libattr.h]) use_xattr=no if test "$ac_cv_header_attr_libattr_h" = yes \ @@ -36,7 +36,8 @@ AC_DEFUN([gl_FUNC_XATTR], AC_MSG_WARN([AC_PACKAGE_NAME will be built without xattr support.]) fi fi - if test $use_xattr = yes; then - AC_DEFINE_UNQUOTED([USE_XATTR], 1) + if test "$use_xattr" = yes; then + AC_DEFINE([USE_XATTR], [1], + [Define to 1 to use the Linux extended attributes library.]) fi ])