From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A7A9F1F47C for ; Wed, 11 Jan 2023 20:40:19 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=clisp.org header.i=@clisp.org header.a=rsa-sha256 header.s=strato-dkim-0002 header.b=cv3WHLNj; dkim-atps=neutral Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFhtC-0000Cs-KR; Wed, 11 Jan 2023 15:40:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFhtA-0000C2-1S for bug-gnulib@gnu.org; Wed, 11 Jan 2023 15:40:00 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.221]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFht8-0006cH-1S for bug-gnulib@gnu.org; Wed, 11 Jan 2023 15:39:59 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1673469595; cv=none; d=strato.com; s=strato-dkim-0002; b=US96wiSoZT3FgjKEvx9Fe5ry/ns1dpaKMN2FP7u9EUrqUUswaEUl9zTy64fZkNEn1O go1vKTl3mUzy6KM42pSPa98KCg7PsPPNfMNX3uXoAjTcYuILlUFG9P8m0uBIVhnFWUc1 EGZ2sexz26MO2fWaYyW+049hYjMc93i69fZ5bPsqP57qF//UGOAX2NPcDppFwLbvl9Ue ycT0WpJ4Vi79FEZpKITLS2oV+I9qWquM3l5AWAoDkdqlMPlFmtQ5m+LfgS8AsQLrSTQy /XQGCarmu4ZG69EQ+2dH+kczgeYrRNTBiAWsJg0CI+LaDSyAekvqWWv3BIGGWc15Q2fu FleA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1673469595; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=VA51jyy8WIlmoKZOyoK/XapgXqMcMlHEeC/VzRFvqTc=; b=lH8t69XeyDdIs8vkGrLk+1u7XOXLLxhEHTXv22qFVQ7YZBMaBzpWeg0V0DFNc11M7H ++zwGLDIG5Tg71EuL3G58zDhy3NIdPgQRvWyPlfSZq/XI8sYsLe9GE3YvO9dhhN23RZr SQYCCHhg8O9Fu/dR5Qlx4pvwIV2SdAj/g/CquJ0DwkCfW28WYC+Qxh9ajVtlqbAfV7lX n7eDBdpwXGFpDcHRtKsAUEViRLeW6UHsmeVMtmIKveEaGI1uVhJ9xIDI2U6b6hj+Zo3W 5qfm34hBq87vvxha2wNm/bNvgeJucuJYO3zjQBrgEKh8RSim4axy+PI0hqRY6vRaRFaU ijTw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1673469595; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=VA51jyy8WIlmoKZOyoK/XapgXqMcMlHEeC/VzRFvqTc=; b=cv3WHLNjIKMvilBa9yNRhs6tuqdFIbXGdlz5yyZIRTtEYN/r7XTvJqy6ROKsuSGgmz n4j9RGAv4gmWPg6nEHudkCFWBBjdjR7BNLas7FaPRxD/mBfvz2ZWBrFkkRr4kC6CvmHB d4ck6RXequTHaf3W45mxAFtJ+2KezFvMrkG3PoOBmiNEpEXvPOGqlIlLf689+gLvNsNB nIn4x06LLP6Kr0tsNUTS8Dl3IKMz7TK/qykFKtRLM8nz8GmB/PY/wPMubyq/F+2De1le RnZC3R7j47ITUvDkHzCcESOmEAJRlMI++yiNRgWaei2EGEwQAhWWTgYLSjaMaSdtwx60 W0Ig== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOV1KfevSn/sVBN8TS9zA9aoIqWAw==" Received: from nimes.localnet by smtp.strato.de (RZmta 48.6.2 AUTH) with ESMTPSA id I8f358z0BKdt2ov (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 11 Jan 2023 21:39:55 +0100 (CET) From: Bruno Haible To: bug-gnulib@gnu.org Subject: spawn-pipe tests: Fix test failure on Android Date: Wed, 11 Jan 2023 21:39:55 +0100 Message-ID: <2129949.AB8Y2P6tQ1@nimes> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: none client-ip=81.169.146.221; envelope-from=bruno@clisp.org; helo=mo4-p00-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org On Android 11, I'm seeing this test failure: FAIL: test-spawn-pipe.sh ======================== ../../gltests/test-spawn-pipe-child.c:134: assertion '! is_open (STDERR_FILENO)' failed test-spawn-pipe.sh: iteration 4 failed ../../gltests/test-spawn-pipe-child.c:134: assertion '! is_open (STDERR_FILENO)' failed test-spawn-pipe.sh: iteration 5 failed ../../gltests/test-spawn-pipe-child.c:134: assertion '! is_open (STDERR_FILENO)' failed test-spawn-pipe.sh: iteration 6 failed ../../gltests/test-spawn-pipe-child.c:134: assertion '! is_open (STDERR_FILENO)' failed test-spawn-pipe.sh: iteration 7 failed FAIL test-spawn-pipe.sh (exit status: 1) This patch fixes it. 2023-01-11 Bruno Haible spawn-pipe tests: Fix test failure on Android. * tests/test-spawn-pipe-child.c (main): Skip the is_open (STDERR_FILENO) check on Android. diff --git a/tests/test-spawn-pipe-child.c b/tests/test-spawn-pipe-child.c index 071beb320f..1d8a27ffd4 100644 --- a/tests/test-spawn-pipe-child.c +++ b/tests/test-spawn-pipe-child.c @@ -127,9 +127,9 @@ main (int argc, char *argv[]) case 1: /* Expect fd 2 is closed. But on HP-UX 11, fd 2 gets automatically re-opened to /dev/null if it - was closed. Similarly on native Windows. Future POSIX will allow - this, see . */ -#if !(defined __hpux || (defined _WIN32 && ! defined __CYGWIN__)) + was closed. Similarly on Android and on native Windows. Future POSIX + will allow this, see . */ +#if !(defined __hpux || defined __ANDROID__ || (defined _WIN32 && ! defined __CYGWIN__)) if (!is_qemu) ASSERT (! is_open (STDERR_FILENO)); #endif