From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EBFC61F453 for ; Thu, 24 Jan 2019 03:25:21 +0000 (UTC) Received: from localhost ([127.0.0.1]:45695 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmVdo-0000Rq-NT for normalperson@yhbt.net; Wed, 23 Jan 2019 22:25:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmVde-0000BP-QW for bug-gnulib@gnu.org; Wed, 23 Jan 2019 22:25:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmVXS-0004yt-J9 for bug-gnulib@gnu.org; Wed, 23 Jan 2019 22:18:47 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::5]:26195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gmVXR-0004vo-TN for bug-gnulib@gnu.org; Wed, 23 Jan 2019 22:18:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1548299922; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=iLdToAcZK97caK62quOkd1TnVrqXk/DMORgaI+NNyRo=; b=MjPinOaWquLfZAb31swUxeXmYMUfHlr5ffp9KLWdk0xEpIezKxQwIWGSGPo9rtl1q9 VsiwqoI7ENR98GDZQ4O52ZRhcoyc43Ncykc+y+YzABjd6DvLJhifsO+tb4wNjlfjkxwf 3ev29Dd6OmAf6BbOZYJgV1eHaBS/jYbV/LBAZzh+ZOpAqcw3DhISiudwmlPBDSfSe+f5 nC727zbXvmanWTTJMNtEx2lm+d1sXZcDHkI2nC2ELaShiYU4AXogLhJZTa3IV0uwYSdY ZFvqLq2KA768EmMa6DxdgIFM366nyoLB4Xo83orMdXv2xv5AhUPAb8XgQbbfq8uWnBSF is8Q== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH+AHjwLuWOGKf2y/s=" X-RZG-CLASS-ID: mo00 Received: from bruno.haible.de by smtp.strato.de (RZmta 44.9 DYNA|AUTH) with ESMTPSA id v0a34ev0O3Ifby5 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Thu, 24 Jan 2019 04:18:41 +0100 (CET) From: Bruno Haible To: "Dmitry V. Levin" Subject: Re: test-rwlock1 failing on latest Fedora Rawhide Date: Thu, 24 Jan 2019 04:18:40 +0100 Message-ID: <2073756.dCBeYvj2K1@omega> User-Agent: KMail/5.1.3 (Linux/4.4.0-141-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20190123223828.GA23722@altlinux.org> References: <20190123193730.GA9768@redhat.com> <20190123222426.GE12500@redhat.com> <20190123223828.GA23722@altlinux.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a01:238:20a:202:5300::5 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Dmitry V. Levin wrote: > According to the log, it was libtool that broke a valid command > > /bin/sh ../../libtool --tag=CC --preserve-dup-deps --mode=link gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -o test-rwlock1 test-rwlock1.o libtests.a ../../gnulib/lib/libgnu.la libtests.a -pthread -Wl,--push-state -Wl,--no-as-needed -lpthread -Wl,--pop-state -lrt > > into an invalid command > > libtool: link: gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -o test-rwlock1 test-rwlock1.o -pthread -Wl,--push-state -Wl,--no-as-needed -Wl,--pop-state libtests.a ../../gnulib/lib/.libs/libgnu.a libtests.a -lpthread -lrt -pthread > > What's the version of libtool that's produced such a mess? Even the latest released libtool versions do this. This patch should fix the issue. Pushed. 2019-01-23 Bruno Haible thread: Force linking with -lpthread, even when --as-needed is in use. Reported by Richard W.M. Jones in . * lib/glthread/thread.h (pthread_create): Don't declare weak. diff --git a/lib/glthread/thread.h b/lib/glthread/thread.h index ca40508..1d2a544 100644 --- a/lib/glthread/thread.h +++ b/lib/glthread/thread.h @@ -133,8 +133,6 @@ extern int glthread_in_use (void); call to foo(...) in the same function. To avoid this, we test the address of a function in libpthread that we don't use. */ -# pragma weak pthread_create - # ifndef pthread_sigmask /* Do not declare rpl_pthread_sigmask weak. */ # pragma weak pthread_sigmask # endif