From: Paul Eggert <eggert@cs.ucla.edu>
To: Bruno Haible <bruno@clisp.org>, bug-gnulib@gnu.org
Cc: 34817@debbugs.gnu.org, Jesse <jesse.caldwell@colorado.edu>
Subject: Re: bug#34817: coreutils 8.31 compile failure on rhel5
Date: Wed, 13 Mar 2019 14:49:10 -0700 [thread overview]
Message-ID: <20672bb0-97a3-7aab-4b6c-47807f3b1f0d@cs.ucla.edu> (raw)
In-Reply-To: <3189085.TABHTxo6TD@omega>
On 3/13/19 11:35 AM, Bruno Haible wrote:
> A simpler fix would have been to mark the 'minus_zero' variable as 'static':
Yes, that would have been a smaller change. Although I originally did
that, there's a reason I went for the larger change.
Making the variable 'static' might cause some compilers to notice that
the variable never changes, so it's a constant, so it can be folded, and
then they (mistakenly) convert -0.0 to 0.0. Originally the variable was
extern and the extern hack prevents most compilers from doing this
incorrect optimization (unless they're doing whole-program optimization,
which typically they aren't). Since making the variable static removed
the hack, I decided it was clearer to use the larger change, which makes
it more obvious that we aren't trying to work around this potential
problem any more.
I hope the issue I mentioned is not a real problem. If it is, we can go
back to the old code except rename the variable so that it's called
"lminus_zero" for the long double case. I considered doing that too, but
that's even more confusing and I hope we don't have to be that confusing.
next prev parent reply other threads:[~2019-03-13 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201903111716.x2BHGEjY016306@refuge.colorado.edu>
2019-03-11 23:42 ` bug#34817: coreutils 8.31 compile failure on rhel5 Paul Eggert
2019-03-13 18:35 ` Bruno Haible
2019-03-13 21:49 ` Paul Eggert [this message]
2019-03-13 22:36 ` Bruno Haible
2019-03-11 23:54 Jesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20672bb0-97a3-7aab-4b6c-47807f3b1f0d@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=34817@debbugs.gnu.org \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
--cc=jesse.caldwell@colorado.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).