gnulib-tool return codes

gnulib-tool return codes

[Jeffrey Walton]

Hi Everyone,

I noticed arpa_inet-c++ tested OK
(https://travis-ci.org/github/noloader/gnulib/jobs/668196404):

****************************************
arpa_inet-c++
****************************************
Tested arpa_inet-c++ OK

But (I'm not sure what was tested):

****************************************
arpa_inet-c++
****************************************
./gnulib-tool: *** file
/home/travis/build/noloader/gnulib/./modules/arpa_inet-c++ not found
./gnulib-tool: *** Stop.
gnulib-tool: warning: module arpa_inet-c++ lacks a License
./gnulib-tool: *** file
/home/travis/build/noloader/gnulib/./modules/arpa_inet-c++ not found
./gnulib-tool: *** Stop.
gnulib-tool: warning: module arpa_inet-c++ doesn't exist
gnulib-tool: warning: module arpa_inet-c++ doesn't exist
configure.ac:8: installing 'build-aux/compile'
configure.ac:4: installing 'build-aux/install-sh'
configure.ac:4: installing 'build-aux/missing'
...

The script is picking up arpa_inet-c++ because it does a find looking
for a filename <module>-tests. In this case arpa_inet-c++-tests is
found.

The test script does check return values
(https://github.com/noloader/gnulib/blob/master/ci_tests/test_modules.sh):

if ! ./gnulib-tool --create-testdir --dir="$test_dir/$module"
"$module" 1>/dev/null;
then
    echo "Failed to prepare $module" | tee -a "$result_file"
    failed_tests=$((failed_tests+1))
fi

I'm guessing gnulib-tool does not return an error?

Jeff

Re: gnulib-tool return codes

[Bruno Haible]

Hi Jeffrey,

> I noticed arpa_inet-c++ tested OK

There's no module named 'arpa_inet-c++':
  - There's no file modules/arpa_inet-c++ ,
  - './gnulib-tool --list' does not mention it.

> The script is picking up arpa_inet-c++ because it does a find looking
> for a filename <module>-tests.

It should also check whether the file modules/<module> exists.

> I'm guessing gnulib-tool does not return an error?

Invalid module names produce a diagnostic, but gnulib-tool then proceeds,
ignoring it.

Bruno