* [PATCH] xalloc-oversized: omit unnecessary cast
@ 2024-02-04 7:54 Paul Eggert
0 siblings, 0 replies; only message in thread
From: Paul Eggert @ 2024-02-04 7:54 UTC (permalink / raw)
To: bug-gnulib; +Cc: Paul Eggert
* lib/xalloc-oversized.h (__xalloc_oversized): Omit unnecessary
cast of a positive in-range value to size_t. This seems to be
left over from an older version of the code.
---
ChangeLog | 5 +++++
lib/xalloc-oversized.h | 3 +--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 088b866362..5246105f57 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2024-02-03 Paul Eggert <eggert@cs.ucla.edu>
+ xalloc-oversized: omit unnecessary cast
+ * lib/xalloc-oversized.h (__xalloc_oversized): Omit unnecessary
+ cast of a positive in-range value to size_t. This seems to be
+ left over from an older version of the code.
+
glob: port better to C23
* lib/glob.c: Include <stdckdint.h>.
(size_add_wrapv): Remove. All uses replaced by ckd_add.
diff --git a/lib/xalloc-oversized.h b/lib/xalloc-oversized.h
index 0b7bb2cee8..7f30f83e76 100644
--- a/lib/xalloc-oversized.h
+++ b/lib/xalloc-oversized.h
@@ -29,8 +29,7 @@
is SIZE_MAX - 1. */
#define __xalloc_oversized(n, s) \
((s) != 0 \
- && ((size_t) (PTRDIFF_MAX < SIZE_MAX ? PTRDIFF_MAX : SIZE_MAX - 1) / (s) \
- < (n)))
+ && (PTRDIFF_MAX < SIZE_MAX ? PTRDIFF_MAX : SIZE_MAX - 1) / (s) < (n))
/* Return 1 if and only if an array of N objects, each of size S,
cannot exist reliably because its total size in bytes would exceed
--
2.40.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-04 7:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 7:54 [PATCH] xalloc-oversized: omit unnecessary cast Paul Eggert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).