From: Khem Raj <raj.khem@gmail.com>
To: bug-gnulib@gnu.org, bruno@clisp.org
Cc: Khem Raj <raj.khem@gmail.com>
Subject: [PATCH v2] lib/posixtm.c: Fixe build error with clang-18
Date: Tue, 16 Jan 2024 15:38:03 -0800 [thread overview]
Message-ID: <20240116233803.3478855-1-raj.khem@gmail.com> (raw)
Clang-18 detects this and flags it as error
x86_64-yoe-linux-clang -target x86_64-yoe-linux -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -mlittle-endian --dyld-prefix=/usr -Qunused-arguments -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/coreutils/9.4/recipe-sysroot -I. -I../coreutils-9.4 -I./lib -Ilib -I../coreutils-9.4/lib -Isrc -I../coreutils-9.4/src -Wno-cast-qual -Wno-conversion -Wno-float-equal -Wno-sign-compare -Wno-undef -Wno-unused-function -Wno-unused-parameter -Wno-float-conversion -Wimplicit-fallthrough -Wno-pedantic -Wno-sign-conversion -Wno-type-limits -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/coreutils/9.4/coreutils-9.4=/usr/src/debug/coreutils/9.4 -fdebug-prefix-map=/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/coreutils/9.4/coreutils-9.4=/usr/src/debug/coreutils/9.4 -fmacro-prefix-map=/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/coreutils/9.4/build=/usr/src/debug/coreutils/9.4 -fdebug-prefix-map=/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/coreutils/9.4/build=/usr/src/debug/coreutils/9.4 -fdebug-prefix-map=/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/coreutils/9.4/recipe-sysroot= -fmacro-prefix-map=/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/coreutils/9.4/recipe-sysroot= -fdebug-prefix-map=/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/coreutils/9.4/recipe-sysroot-native= -c -o lib/libcoreutils_a-posixtm.o `test -f 'lib/posixtm.c'
lib/posixtm.c:194:15: error: operand argument to checked integer operation must be an integer type other than plain 'char', 'bool', bit-precise, or an enumeration ('bool' invalid)
194 | if (ckd_add (&t, t, leapsec))
| ^~~~~~~~~~~~~~~~~~~~~~~~
usr/lib/clang/18/include/stdckdint.h:37:54: note: expanded from macro 'ckd_add'
37 | #define ckd_add(R, A, B) __builtin_add_overflow((A), (B), (R))
| ^~~
1 error generated.
* lib/posixtm.c (posixtime): Fix operand argument to checked
integer operation.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
ChangeLog | 5 +++++
lib/posixtm.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index e42d2c31ab..daca27a917 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2024-01-15 Khem Raj <raj.khem@gmail.com>
+
+ * lib/posixtm.c (posixtime): Fix operand argument to checked
+ integer operation.
+
2024-01-07 Jim Meyering <meyering@meta.com>
update-copyright: handle more cases
diff --git a/lib/posixtm.c b/lib/posixtm.c
index ef9f55f873..23397a6672 100644
--- a/lib/posixtm.c
+++ b/lib/posixtm.c
@@ -159,7 +159,7 @@ bool
posixtime (time_t *p, const char *s, unsigned int syntax_bits)
{
struct tm tm0;
- bool leapsec = false;
+ int leapsec = 0;
if (! posix_time_parse (&tm0, s, syntax_bits))
return false;
--
2.43.0
next reply other threads:[~2024-01-16 23:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 23:38 Khem Raj [this message]
2024-01-17 1:25 ` [PATCH v2] lib/posixtm.c: Fixe build error with clang-18 Paul Eggert
2024-01-17 1:39 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116233803.3478855-1-raj.khem@gmail.com \
--to=raj.khem@gmail.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).