From: Ondrej Valousek <ondrej.valousek.xm@renesas.com>
To: bug-gnulib@gnu.org, bruno@clisp.org
Cc: Ondrej Valousek <ondrej.valousek.xm@renesas.com>
Subject: [PATCH] Improve comments for [q]set-acl.c
Date: Tue, 17 Jan 2023 14:28:34 +0100 [thread overview]
Message-ID: <20230117132833.1730306-1-ondrej.valousek.xm@renesas.com> (raw)
Hi Bruno, sorry, this patch should be fine now.
It improve comments for both functions
---
lib/qset-acl.c | 14 +++++++-------
lib/set-acl.c | 18 +++++++++---------
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/lib/qset-acl.c b/lib/qset-acl.c
index c3442d060f..aecab8ead3 100644
--- a/lib/qset-acl.c
+++ b/lib/qset-acl.c
@@ -26,13 +26,13 @@
#include "acl-internal.h"
-
-/* Set the access control lists of a file. If DESC is a valid file
- descriptor, use file descriptor operations where available, else use
- filename based operations on NAME. If access control lists are not
- available, fchmod the target file to MODE. Also sets the
- non-permission bits of the destination file (S_ISUID, S_ISGID, S_ISVTX)
- to those from MODE if any are set.
+/* Set the access control lists of a file to match *exactly* MODE (this might
+ remove inherited ACLs). Note chmod() tends to honor inherited/default
+ ACLs. If DESC is a valid file descriptor, use file descriptor operations
+ where available, else use filename based operations on NAME. If access
+ control lists are not available, fchmod the target file to MODE. Also
+ sets the non-permission bits of the destination file
+ (S_ISUID, S_ISGID, S_ISVTX) to those from MODE if any are set.
Return 0 if successful. Return -1 and set errno upon failure. */
int
diff --git a/lib/set-acl.c b/lib/set-acl.c
index 9111911864..0d20850444 100644
--- a/lib/set-acl.c
+++ b/lib/set-acl.c
@@ -28,15 +28,15 @@
#include "gettext.h"
#define _(msgid) gettext (msgid)
-
-/* Set the access control lists of a file. If DESC is a valid file
- descriptor, use file descriptor operations where available, else use
- filename based operations on NAME. If access control lists are not
- available, fchmod the target file to MODE. Also sets the
- non-permission bits of the destination file (S_ISUID, S_ISGID, S_ISVTX)
- to those from MODE if any are set.
- Return 0 if successful. On failure, output a diagnostic, set errno and
- return -1. */
+/* Set the access control lists of a file to match *exactly* MODE (this might
+ remove inherited ACLs). Note chmod() tends to honor inherited/default
+ ACLs. If DESC is a valid file descriptor, use file descriptor operations
+ where available, else use filename based operations on NAME. If access
+ control lists are not available, fchmod the target file to MODE. Also
+ sets the non-permission bits of the destination file
+ (S_ISUID, S_ISGID, S_ISVTX) to those from MODE if any are set.
+ Return 0 if successful. On failure, output a diagnostic, set errno and
+ return -1. */
int
set_acl (char const *name, int desc, mode_t mode)
--
2.39.0
next reply other threads:[~2023-01-17 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 13:28 Ondrej Valousek [this message]
2023-01-17 14:27 ` [PATCH] Improve comments for [q]set-acl.c Bruno Haible
[not found] <20230117173117.1735089-1-ondrej.valousek.xm@renesas.com>
2023-01-17 18:33 ` Bruno Haible
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117132833.1730306-1-ondrej.valousek.xm@renesas.com \
--to=ondrej.valousek.xm@renesas.com \
--cc=bruno@clisp.org \
--cc=bug-gnulib@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).