From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 32A591F953 for ; Thu, 9 Dec 2021 15:44:15 +0000 (UTC) Received: from localhost ([::1]:45656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mvLaf-0003Iv-Rl for normalperson@yhbt.net; Thu, 09 Dec 2021 10:44:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvLaS-0003Ie-KZ for bug-gnulib@gnu.org; Thu, 09 Dec 2021 10:44:00 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:39022) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mvLaQ-0008IS-2Z for bug-gnulib@gnu.org; Thu, 09 Dec 2021 10:44:00 -0500 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B9DtvTU015248; Thu, 9 Dec 2021 15:43:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=AdbPW7VEfnxX9k+u1qeIHM9sG1LvaDwBF7sstlZJt6M=; b=DZDPLfCcYkQvXOUudqbRXwUD4VPlgDErbYyGU4j9LIem99LFWkGHizG2ceuDNCkA57c3 uPlcGZ3HUo5lL9Bg0Wiflc4zvgk2xFhlw8BVtw3wu6p3AaSQZbXnAKORXTNuOOKVGNDR g5mR17D4ncGLpDKFBofFI/FecPqy6hSZgunYYb64SGAkfjsKf0KSxakXHTXlpDEPVYwD nQb20anQhIcKnFU4Y7JOCQoSYbsfpGU+txWeVrAkELqTqIQVWFsXYz0FWgUDwljBRFOP NY1gV3/yQ0kK74mF13Ci3BBxD1SMagTbNvriGh6qG8N/XIlAAjD088evdfvgsY/WJgj6 zw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ctt9muhwj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Dec 2021 15:43:41 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1B9FfHQ0181742; Thu, 9 Dec 2021 15:43:40 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by userp3030.oracle.com with ESMTP id 3cqwf2ayux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Dec 2021 15:43:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GvDsmZgPXII+gCpNbb1ZPE6BeiFwyiLHoEvwvhFfPkSJTbk2Pu/zD/rnAMOVSdFsnhYl16wabqOKwyZJUrEjSg46qLgqfZIWZQ9jXCTl5RpQHeIjoMUDRo/iI/q4ogrefnx0IZInBRjiNmyKBTdpopj93yH6GLbRlCxEuEWxbIpGXhwNsweyMKQw2sXv3wGB/WLkpQh+n7/FD8ztwCuhTABLWB11gXSdyn3av/ni2Uy8PQTkicxwpMumqZyMkNT57L3lhCgnCMzTK7gWF845xMyk5c0kULTmOZUx2c4DoU/4nH/iUdazrJ0CEypEAJNnevLIiMC5K3f2AqrlHfjaxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AdbPW7VEfnxX9k+u1qeIHM9sG1LvaDwBF7sstlZJt6M=; b=eA6yllrzBWOkaVRfFfUMIRX7qva6ypwLiQTZM72FIwzDkHY5RiXc2t5VvZIZZZ3vAbIGMVq3wQ4godaTqMegVmalXsihMvko3F0pDEVcAy5pvJjeQLWhy4XuSlNJsMVRk9pex9eTbvCoNyLpGzHh7CnkQsiKNIhSL1x+m91CS0WZ/vYTd6EmFglfw1IWKA5vQrH3UTbRfIai5/ZkgZ0dW0CBCfR5dh5Np/LNQeUg4jehevp+sTNdDWliPxi/bACVfgTbJFfZpyY5qETPus9sIM2Oq02oH+vPuZ9BYDtaY53Al2MAsFNg88TMgQ3C0NCOsrlIXdqXNw2p5bLN/36L7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AdbPW7VEfnxX9k+u1qeIHM9sG1LvaDwBF7sstlZJt6M=; b=Kkn8O0AEjSONd8ZS2SOB4a4QlXtv1iXbnbeapncK9AU2ziRn0e/qGyyi+yQq7wXHgHzbURusUbnCXoTQrYlejKPRm5ej8eOZeGKeNkZhPcXlrvgkWWcZY0jNzCYlPKN4OcWpspimF9oNPAuBorTynBtAaFHRnF/nvQ3PxStdPKs= Received: from CO6PR10MB5426.namprd10.prod.outlook.com (2603:10b6:5:35e::22) by CO1PR10MB4532.namprd10.prod.outlook.com (2603:10b6:303:6d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11; Thu, 9 Dec 2021 15:43:38 +0000 Received: from CO6PR10MB5426.namprd10.prod.outlook.com ([fe80::8ce2:5d61:63af:eb84]) by CO6PR10MB5426.namprd10.prod.outlook.com ([fe80::8ce2:5d61:63af:eb84%8]) with mapi id 15.20.4690.027; Thu, 9 Dec 2021 15:43:38 +0000 Date: Thu, 9 Dec 2021 16:43:28 +0100 From: Daniel Kiper To: Robbie Harwood Subject: Re: [PATCH 01/11] Fix base64 module to work with grub codebase Message-ID: <20211209154328.ia7uvikb7ak2k6j3@tomti.i.net-space.pl> References: <20211025215543.111906-1-rharwood@redhat.com> <20211025215543.111906-2-rharwood@redhat.com> <87y26eafbr.fsf@latte.josefsson.org> <92994199-58a4-7074-1a8e-1c0eb6bfaeb0@cs.ucla.edu> <20211123162431.fxtzfikppwq4xqpr@tomti.i.net-space.pl> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211123162431.fxtzfikppwq4xqpr@tomti.i.net-space.pl> User-Agent: NeoMutt/20170113 (1.7.2) X-ClientProxiedBy: FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) To CO6PR10MB5426.namprd10.prod.outlook.com (2603:10b6:5:35e::22) MIME-Version: 1.0 Received: from tomti.i.net-space.pl (84.10.22.86) by FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.25 via Frontend Transport; Thu, 9 Dec 2021 15:43:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5d3b552-35c4-45a4-bd93-08d9bb2aaae8 X-MS-TrafficTypeDiagnostic: CO1PR10MB4532:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l2cETDp1QkoAsF9dslauMyGfieOeI6w5yw/sIFt8BI1cTHx6mbiXxxfSycwiDxyOZ/vSd56Yom9EZ2q7GkSAXHCMOnXLBciQe774oSUZfr6xYSwSgxiVbVRDOSjo5V+Zy13HX6CBnOX0AgJqrSchxoC3R9Wgbio5wHS36gEu6lx4Vq/SN+g3AoyZi/xdbQ3FQeVoj4vp+/XYwOgJZgEIUKVW/MpVjbNRExrCB+v9PrIGvxfLPVBE7E4byW5Nq+ZsYEIki04Pe2Z+aeVQ5CyFi/dT0PoeRF6ViB9mjxWLqTzOlhmQFXTz+2C4GTrjcMsS27St3YyBqedWuukIsZMNyjwaSDoYE4kXh8N6gezwaUBvczph5qq+YBIQr5gh+nLNbMzKak6j2DtxSjiERHRV1lvKaVt1TgZaKMiidJ8MxijNIDz+5x/NJUeRHFzqIpiPhm/S4xMqy8fEHRAUkE9ZDv4Td4NFp0lDMgL69kWPEyEQFKewa9fAMMnLa+Yqb/PvcjVx+aiIVoJZs+gIDEIyWwS5t2bm64sURNXunmyUbDPOiQ9WZqkVVw+1NmRHwr9CY4dZsWK1/5RBsSQ/JLjezRj809F2b+/I9+OxCyR3DPbA+1PGHgJvv/FLeau+0pVN6B3eF8haNVImdbaJthn8ztDI7xRgqDbx1wt+dWxcDmKaFACrUeua9J+psGbVXMNSKgxB+wDPxK1QM7cGPR6dvw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR10MB5426.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6506007)(66946007)(6666004)(38350700002)(956004)(38100700002)(508600001)(8676002)(55016003)(53546011)(54906003)(1076003)(86362001)(6916009)(52116002)(7696005)(316002)(9686003)(5660300002)(8936002)(26005)(66556008)(44832011)(2906002)(4326008)(66476007)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f9Dwkxhfm3paiOmOHoenXeeZa3E1jcBrX+A6tk3NtF1k+E4G/8lE34A3RSkq?= =?us-ascii?Q?K87DZTL0ISYyrUUoD87XVAjPtqNT/pufUQlJtSh4KmPU2aBh7BFhrfUGn5lw?= =?us-ascii?Q?KjgdPEC+QKrm8fge6RgDE9WXXD18/7pirb3tcGkKG+Dr2b499R9bs4BXT5WQ?= =?us-ascii?Q?lcYzL0MgNGnDPFr45HF0Z7p31S4ZBqeJYUQxFxkQKr1erd8GlPu7qUeFjlXm?= =?us-ascii?Q?iKosu9Vr8Jtu6n+iQOaVag8Agg2nsIz+MMN1oQaKy1OydaIC62WixPT9Zp/v?= =?us-ascii?Q?Dge+Pa9MdYmNIz1RL4hXz+FGvvFURSa0Z8dVAIfrxFATwJOaLxZjXsvX0J0Q?= =?us-ascii?Q?pNWhCfeAmuSqL1/hKdrXP3uiPjSbydyKuxq81dzNe/Uo7doix4LhiGBxBXIg?= =?us-ascii?Q?OqJODT7IOg7uRdLNVZRD5Jmm63jOiFAQftcgX8s3zQANFiYyfFXpm2Jtyk3L?= =?us-ascii?Q?lkslQWx5mjYuUKFG4YZ81V6MjP/M5Y1QBu8lGuNUWOGaNNTLWDHEhmzPkXAK?= =?us-ascii?Q?mr5PMqDaI6z49kwYMq3aBOzISJPgDJi48j16nqWcC+xyGo+3w98DQhblE3B3?= =?us-ascii?Q?Ri4xKRMUrMk3nMFrYvkq8vMCNprFjWHH6oiV3F5+ASKe7a55H/T9310Z6MQS?= =?us-ascii?Q?BdCH1Ey/Bw04XavNEv/InrttrgINO0Vz/8E0J1k19avYBaizRVk9iebj5sXR?= =?us-ascii?Q?uhbEsiQB+NWMlK1ryZMJUrX+Dv2wC8bA5LubpR59vnzU+3XTaGGyjikHDF4T?= =?us-ascii?Q?jVR7X57m0RDKipp8PuiyceDJw1OYs171Irjrz5ojKxaXXT4TEjxgn9H6m75T?= =?us-ascii?Q?BZBhzU1dSqq7lA7Ih7RRMXQOHgqFIChIqQKp9EwDpFb/GHw1EDToFPfI3leN?= =?us-ascii?Q?5N175HHbEx0D4GaW4DCCncfvxtV4mzUs60VE6LHCAX1F8QqVSb2oTj4gMDKH?= =?us-ascii?Q?Uhm5p1v4PyN/ViLiA7cV9YkRxVpaJZU/CP9a7xAf9WQwXEiIL8zN2HqZ3bBq?= =?us-ascii?Q?gC19QmkttnqZOfwQxpIXB9TyWF89nNqT4hthPOGTTTmKGtT0AkSUyF4OGBIi?= =?us-ascii?Q?l9h1xdP6t9+yY3tqzjvpPsj5xFBiOJgZ6qVDe7yAPcyVlkZwnbGdMmgo47Y3?= =?us-ascii?Q?HGjVOIis89p0UVf0lINXohRB76N0g2rx8LDKGuMbBIZRyByw2bgGAh72uph3?= =?us-ascii?Q?d8EpR0wYFSANh7TYPk5OdO0SaRH8gupA5c+966recWqTKIycY1V0tMhGW48I?= =?us-ascii?Q?m7ZyM9O42ufe08MHRF++kbYAa7kCPp9cQOedcgIaplra70xQVZhMJKeAzhSw?= =?us-ascii?Q?I3PJCfTpTczkglTNjiNyb/ysV66EuZ0GbFkvrUj113JMIJylfQkbNd0FaYYi?= =?us-ascii?Q?2YvsApZIDSvMRaDaNCOp1sLIvwUyCmqiE0sqJrmsahyCqoqd277gbPVHz3gh?= =?us-ascii?Q?/m303RkhD6L+NWxNuRDtMW3p+NXUCdfUG5Rw/8M0zhEBlm9cmrbujM3CuPFt?= =?us-ascii?Q?Ms9AVKE/xuyYDoTXQI7wbFpZXOi9ZAkPwizq7diemLSnSXatrNc7Rif1eB4Y?= =?us-ascii?Q?LA9U+Sb/1yKa3qglBVm6hYurRbW+PHYBJ5fUC8U41ApT+0zHlHopAPVjpMwj?= =?us-ascii?Q?7tq9m6lkqJC17U+MVVcs9KQ=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5d3b552-35c4-45a4-bd93-08d9bb2aaae8 X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5426.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2021 15:43:38.2953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mqqsx9NhDGLO3oiXeQdwilFd3TqAJODCzQkNwcQWHZYBCKtaB/Drz74PgxgRAWQQF53m+DABxwUqpylgNgDf5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4532 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10192 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112090085 X-Proofpoint-GUID: azuaKDwydAhzLezE-w99xGAW4GsQ6TTl X-Proofpoint-ORIG-GUID: azuaKDwydAhzLezE-w99xGAW4GsQ6TTl Received-SPF: pass client-ip=205.220.177.32; envelope-from=daniel.kiper@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Josefsson , Patrick Steinhardt , Paul Eggert , bug-gnulib@gnu.org Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" Bumping the thread... Please take a look below... On Tue, Nov 23, 2021 at 05:24:31PM +0100, Daniel Kiper wrote: > CC-ing Vladimir... > > On Tue, Nov 09, 2021 at 02:34:25PM -0500, Robbie Harwood wrote: > > Paul Eggert writes: > > > On 10/28/21 12:32, Robbie Harwood wrote: > > > > > >> I don't know why Patrick chose to > > >> not use that instead, but a local test seems to work. > > > > > > Is grub2 intended to be portable to compilers that don't support > > > ? If that's the issue, I suggest that grub2 stop worrying > > > that. Surely every compiler of interest to grub2 supports > > > already. And if you really need to support older compilers, the Gnulib > > > stdbool module should suffice. > > > > > >> grub2 shims out config.h for some build targets (e.g., when not building > > >> utilities). > > > > > > Why does it need to do that? Is this because of cross-building, and > > > where is for the utilities platform which is not the same as > > > the target platform? If so, that suggests that you should run two > > > 'configure' instances, one for the utilities and one for the target, and > > > compile the base64 module twice if it's used in both places. > > > > I'll defer to Daniel on why things are the way they are, but I don't > > disagree with you. > > Vladimir told me once we are doing that because otherwise we would be > leaking too many "OS specific things" into the GRUB core and modules > which run on top firmware/bare metal instead of the OS. I hope he will > be able to tell us more here... > > Vladimir? Vladimir, could you give us examples of leaks? Daniel