From: Daniel Kiper <daniel.kiper@oracle.com>
To: Robbie Harwood <rharwood@redhat.com>
Cc: Simon Josefsson <simon@josefsson.org>,
Patrick Steinhardt <ps@pks.im>, Paul Eggert <eggert@cs.ucla.edu>,
bug-gnulib@gnu.org
Subject: Re: [PATCH 01/11] Fix base64 module to work with grub codebase
Date: Tue, 23 Nov 2021 17:24:31 +0100 [thread overview]
Message-ID: <20211123162431.fxtzfikppwq4xqpr@tomti.i.net-space.pl> (raw)
In-Reply-To: <jlg7ddh15tq.fsf@redhat.com>
CC-ing Vladimir...
On Tue, Nov 09, 2021 at 02:34:25PM -0500, Robbie Harwood wrote:
> Paul Eggert <eggert@cs.ucla.edu> writes:
>
> > On 10/28/21 12:32, Robbie Harwood wrote:
> >
> >> I don't know why Patrick chose to
> >> not use that instead, but a local test seems to work.
> >
> > Is grub2 intended to be portable to compilers that don't support
> > <stdbool.h>? If that's the issue, I suggest that grub2 stop worrying
> > that. Surely every compiler of interest to grub2 supports <stdbool.h>
> > already. And if you really need to support older compilers, the Gnulib
> > stdbool module should suffice.
> >
> >> grub2 shims out config.h for some build targets (e.g., when not building
> >> utilities).
> >
> > Why does it need to do that? Is this because of cross-building, and
> > where <config.h> is for the utilities platform which is not the same as
> > the target platform? If so, that suggests that you should run two
> > 'configure' instances, one for the utilities and one for the target, and
> > compile the base64 module twice if it's used in both places.
>
> I'll defer to Daniel on why things are the way they are, but I don't
> disagree with you.
Vladimir told me once we are doing that because otherwise we would be
leaking too many "OS specific things" into the GRUB core and modules
which run on top firmware/bare metal instead of the OS. I hope he will
be able to tell us more here...
Vladimir?
Anyway, I would be more than happy if we could find better way generating
configs for the GRUB.
Daniel
next prev parent reply other threads:[~2021-11-23 16:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 21:55 [PATCH 00/11] Code hygiene fixes from grub Robbie Harwood
2021-10-25 21:55 ` [PATCH 01/11] Fix base64 module to work with grub codebase Robbie Harwood
2021-10-27 11:15 ` Simon Josefsson via Gnulib discussion list
2021-10-28 19:32 ` Robbie Harwood
2021-11-09 18:35 ` Simon Josefsson via Gnulib discussion list
2021-11-09 18:52 ` Paul Eggert
2021-11-09 19:34 ` Robbie Harwood
2021-11-23 16:24 ` Daniel Kiper [this message]
2021-12-09 15:43 ` Daniel Kiper
2021-10-25 21:55 ` [PATCH 02/11] argp-parse.c (__argp_input): Don't crash if pstate is NULL Robbie Harwood
2021-10-25 21:55 ` [PATCH 03/11] gnulib/regexec: Fix possible null-dereference Robbie Harwood
2021-10-25 21:55 ` [PATCH 04/11] gnulib/regexec: Resolve unused variable Robbie Harwood
2021-10-25 21:55 ` [PATCH 05/11] Fix width computation Robbie Harwood
2021-10-25 21:55 ` [PATCH 06/11] Make gnulib's regcomp not abort() Robbie Harwood
2021-10-25 21:55 ` [PATCH 07/11] Make CFLAGS less painful Robbie Harwood
2021-10-25 21:55 ` [PATCH 08/11] Fix __argp_fmtstream_point()'s return type and comparisons with it Robbie Harwood
2021-10-25 21:55 ` [PATCH 09/11] Fix up a bunch of "gcc -Werror=sign-compare" complaints Robbie Harwood
2021-10-25 21:55 ` [PATCH 10/11] Paper over a stringop-overflow warning about wide char handling Robbie Harwood
2021-10-25 21:55 ` [PATCH 11/11] Fixup for -Werror=ignored-qualifiers issues Robbie Harwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.gnu.org/mailman/listinfo/bug-gnulib
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123162431.fxtzfikppwq4xqpr@tomti.i.net-space.pl \
--to=daniel.kiper@oracle.com \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=ps@pks.im \
--cc=rharwood@redhat.com \
--cc=simon@josefsson.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).