From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS22989 209.51.188.0/24 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id ADFF31F8C6 for ; Mon, 2 Aug 2021 01:20:23 +0000 (UTC) Received: from localhost ([::1]:48904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAMcu-0001Ul-H0 for normalperson@yhbt.net; Sun, 01 Aug 2021 21:20:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAMc1-0007uP-2b for bug-gnulib@gnu.org; Sun, 01 Aug 2021 21:19:25 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAMbx-00011h-6f for bug-gnulib@gnu.org; Sun, 01 Aug 2021 21:19:24 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A14B216011A for ; Sun, 1 Aug 2021 18:19:09 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id uUbbMpp-jc_O; Sun, 1 Aug 2021 18:19:08 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CE86B160108; Sun, 1 Aug 2021 18:19:08 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ht6TMMfsh7QV; Sun, 1 Aug 2021 18:19:08 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AA543160101; Sun, 1 Aug 2021 18:19:08 -0700 (PDT) From: Paul Eggert To: bug-gnulib@gnu.org Subject: [PATCH 15/27] system-quote: improve -fanalyzer malloc checking Date: Sun, 1 Aug 2021 18:18:09 -0700 Message-Id: <20210802011821.1057057-15-eggert@cs.ucla.edu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210802011821.1057057-1-eggert@cs.ucla.edu> References: <20210802011821.1057057-1-eggert@cs.ucla.edu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Eggert Errors-To: bug-gnulib-bounces+normalperson=yhbt.net@gnu.org Sender: "bug-gnulib" --- ChangeLog | 2 +- lib/system-quote.h | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6c81691fb..7ef3676a6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -5,7 +5,7 @@ * lib/canonicalize.h, lib/dfa.h, lib/dirname.h, lib/exclude.h: * lib/filenamecat.h, lib/malloca.h, lib/modechange.h: * lib/mountlist.h, lib/pagealign_alloc.h, lib/quotearg.h: - * lib/readutmp.h, lib/savedir.h, lib/sh-quote.h: + * lib/readutmp.h, lib/savedir.h, lib/sh-quote.h, lib/system-quote.h: Add malloc-related attributes and include stdlib.h as needed. * lib/dfa.c: Include verify.h. (assume_nonnull): New macro. diff --git a/lib/system-quote.h b/lib/system-quote.h index f378950e9..b1bbf6521 100644 --- a/lib/system-quote.h +++ b/lib/system-quote.h @@ -47,6 +47,7 @@ */ =20 #include +#include =20 #ifdef __cplusplus extern "C" { @@ -84,13 +85,17 @@ extern char * /* Returns the freshly allocated quoted string. */ extern char * system_quote (enum system_command_interpreter interpreter, - const char *string); + const char *string) + _GL_ATTRIBUTE_MALLOC _GL_ATTRIBUTE_DEALLOC_FREE + _GL_ATTRIBUTE_RETURNS_NONNULL; =20 /* Returns a freshly allocated string containing all argument strings, q= uoted, separated through spaces. */ extern char * system_quote_argv (enum system_command_interpreter interpreter, - char * const *argv); + char * const *argv) + _GL_ATTRIBUTE_MALLOC _GL_ATTRIBUTE_DEALLOC_FREE + _GL_ATTRIBUTE_RETURNS_NONNULL; =20 #ifdef __cplusplus } --=20 2.31.1